Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: accelerate TestMemCount #19581

Merged
merged 8 commits into from
Aug 29, 2020
Merged

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Aug 28, 2020

What problem does this PR solve?

relate to http://github.com/pingcap/tidb/pull/19578

Problem Summary:
Accelerate the test func TestMemCount. Before this commit, it'll cost 807.068s to run the test which may cause a timeout.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

N/A

Check List

Tests

N/A

Side effects
N/A

Release note

  • No release note

@XuHuaiyu XuHuaiyu requested a review from a team as a code owner August 28, 2020 09:12
@XuHuaiyu XuHuaiyu requested review from qw4990 and removed request for a team August 28, 2020 09:12
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
@b41sh
Copy link
Member

b41sh commented Aug 28, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 28, 2020
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Aug 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit f3c8b00 into pingcap:master Aug 29, 2020
@XuHuaiyu XuHuaiyu deleted the testmemcount branch August 31, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants