table: use evalBuffer to improve performance of lo ... (#18818) #19649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/transaction
|
@imtbkcat please accept the invitation then you can push to the cherry-pick pull requests. |
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
jackysp
approved these changes
Sep 3, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
zz-jason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18818 to release-4.0
What problem does this PR solve?
Issue Number: close #16667
Problem Summary:
MutRowFromDatumsis so heavy that causelocatePartitionperformance worse than expected. Especially inLOAD DATA, partition table need nearly twice time than general table.What is changed and how it works?
What's Changed:
partition by hash(col)orpartition by range(col), get integer value directly.evalBufferto avoidMutRowFromDatumsrepeatly.How it Works:
This two method will avoid using
MutRowFromDatumsmany times. improve the write performance of partition table.Related changes
Check List
Tests
Side effects
Release note