-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix incorrect implementation in builtinRealIsFalseSig
#19658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fix this issue too. |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/merge |
/run-all-tests |
@qw4990 merge failed. |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #19670 |
What problem does this PR solve?
Issue Number: close #18674
Problem Summary: fix incorrect implementation in
builtinRealIsFalseSig
What is changed and how it works?
Fix incorrect implementation in
builtinRealIsFalseSig
.The type of its child is
Real
, but when checking false values, it regards them asInt
incorrectly.Check List
Tests
Release note
builtinRealIsFalseSig