Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incorrect implementation in builtinRealIsFalseSig #19658

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 1, 2020

What problem does this PR solve?

Issue Number: close #18674

Problem Summary: fix incorrect implementation in builtinRealIsFalseSig

What is changed and how it works?

Fix incorrect implementation in builtinRealIsFalseSig.

The type of its child is Real, but when checking false values, it regards them as Int incorrectly.

Check List

Tests

  • Unit test

Release note

  • expression: fix incorrect implementation in builtinRealIsFalseSig

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@SunRunAway
Copy link
Contributor

mysql> select -1.0 % -1.0;
+-------------+
| -1.0 % -1.0 |
+-------------+
|        -0.0 |
+-------------+
1 row in set (0.00 sec)

Please fix this issue too.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2020

mysql> select -1.0 % -1.0;
+-------------+
| -1.0 % -1.0 |
+-------------+
|        -0.0 |
+-------------+
1 row in set (0.00 sec)

Please fix this issue too.

OK

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 1, 2020
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19547
  • 19640

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@qw4990 merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7690e29 into pingcap:master Sep 1, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

% operator gives -0 wrong result when the operator is float, and the -0 is not false
4 participants