privilege: add privilege check for show stats (#19702)
#19760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/privilege
sig/execution
|
@imtbkcat please accept the invitation then you can push to the cherry-pick pull requests. |
|
Please address conflict @imtbkcat |
added 2 commits
September 7, 2020 10:55
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
imtbkcat
force-pushed
the
release-4.0-862d8b899699
branch
from
e140eac
to
ca720fc
Compare
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch. |
|
LGTM |
ti-srebot
added
status/LGT2
tiancaiamao
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19702 to release-4.0
What problem does this PR solve?
Issue Number: close #17782
Problem Summary:
Command like
SHOW STATS_METAandSHOW STATS_BUCKETSdidn't check privilege before. This will lead to table information leak, any user could see some table information by usingSHOW STATS.What is changed and how it works?
What's Changed:
Add privilege check for
SHOW STATSrelated command.How it Works:
Only user with
SELECTprivilege onmysqldatabase could executeSHOW STATSRelated changes
Check List
Tests
Side effects
Release note
SHOW STATS_META,SHOW STATS_BUCKET.