Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add partition should not take table information (#19671) #19891

Merged
merged 3 commits into from
Sep 9, 2020
Merged

ddl: add partition should not take table information (#19671) #19891

merged 3 commits into from
Sep 9, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19671 to release-4.0

What problem does this PR solve?

Issue Number: close #19596

Problem Summary:
alter table t add partition (partition p1 values less than (a)); will pass partition check if a is column of table t

What is changed and how it works?

  • use empty table info in ParseSimpleExprWithTableInfo

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

  • fix an issue that unexpect sucess partition alter

@xiongjiwei @ti-srebot
cherry pick pingcap#19671 to release-4.0
d9f43a6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
@ti-srebot ti-srebot added component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra type/4.0-cherry-pick labels Sep 8, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 8, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/run-all-tests

AilinKid
AilinKid reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
zimulala
zimulala approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 9, 2020
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Sep 9, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

tangenta
tangenta reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2020
@ti-srebot ti-srebot merged commit fc4fea9 into pingcap:release-4.0 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@tangenta tangenta tangenta left review comments

@zimulala zimulala zimulala approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@zimulala zimulala

Labels
component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ti-srebot @AilinKid @zimulala @tangenta @xiongjiwei