ddl: improve the processing speed of general DDL jobs #19997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
AilinKid
reviewed
Sep 16, 2020
| @@ -0,0 +1,102 @@ | |||
| // Copyright 202- PingCAP, Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 202- PingCAP, Inc. | |
| // Copyright 2020- PingCAP, Inc. |
| type DDLJobSubscriber interface { | ||
| // WaitNewDDLJob return a channel for new ddl job notify | ||
| WaitNewDDLJob(ctx context.Context) clientv3.WatchChan | ||
| // NotifyNewDDLJob when dll job enqueue |
There was a problem hiding this comment.
Suggested change
| // NotifyNewDDLJob when dll job enqueue | |
| // NotifyNewDDLJob when ddl job enqueue |
| } | ||
|
|
||
| func (sub *ddlJobSubscirber) WaitNewDDLJob(ctx context.Context) clientv3.WatchChan { | ||
| return sub.etcdCli.Watch(ctx, "/tidb//ddl/job/reverse") |
| case <-w.ctx.Done(): | ||
| return | ||
| if d.ownerManager.IsOwner() { | ||
| select { |
There was a problem hiding this comment.
| NotifyNewDDLJob(ctx context.Context) error | ||
| // WaitDDLJobDone return a channel for ddl job doned notify | ||
| WaitDDLJobDone(ctx context.Context, jobID int64) clientv3.WatchChan | ||
| // NotifyDDLJobDone when dll job dequeue |
| return &mockDDLJobSubscriber{childCtx, cancelFunc} | ||
| } | ||
|
|
||
| func (sub *mockDDLJobSubscriber) WaitNewDDLJob(ctx context.Context) clientv3.WatchChan { |
There was a problem hiding this comment.
seem WaitNewDDLJob and WaitDDLJobDone will block on this? the channel returned here doesn't have the input.
1 task
|
There is no reward for this challenge pull request, so you can request a reward from @zimulala. |
1 similar comment
|
There is no reward for this challenge pull request, so you can request a reward from @zimulala. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #14770
This is a tentative proposal may be wrong, I am not so sure this proposal work better than before program.
@zimulala PTAL, I really need some advices.
Problem Summary:
What is changed and how it works?
What's Changed:
doDDLJobcalled on non-owner TiDB serverdoDDLJobcalled on non-owner TiDBHow it Works:
/tidb//ddl/job/reversein select loop whendoDDLJobcalled on non-owner TiDB/tidb//ddl/job/reversewhendoDDLJobcalleddoDDLJobcalled on non-owner TiDB/tidb/ddl/job/done/{jobID}as DDL job done notification when callrunDDLJoband job state is synced or cancelledCheck List
Release note
Improve the processing speed of general DDL jobs