executor: fix unexpected 'invalid auto-id' error in pessimistic txn retry (#20123) #20134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
|
Sorry @lzmhhh123, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20123 to release-4.0
What problem does this PR solve?
Problem Summary:
In a high load cluster, the error
[variable:8053]Cannot get a valid auto-ID when retrying the statementis reported frequently.TiDB always reuse the allocated auto-ids in the retry stage by saving them to the session variable
RetryInfo. At the beginning of retry, one should resetRetryInfooffset first to keep things correct.Optimistic txn retries in the commit phase:
session.retry().Pessimistic txn retries when the statement is executed:
ExecStmt.handlePessimisticDML.ExecStmt.handlePessimisticDMLdoes not resetRetryInfooffset, results in the auto-ids cannot be reused.What is changed and how it works?
What's Changed: make
ExecStmt.handlePessimisticDMLresetRetryInfooffset.Related changes
Check List
Tests
Side effects
N/A
Release note