DDL: create table should not allow explicit empty name index #20617

watchpoints · 2020-10-24T05:01:17Z

What problem does this PR solve?

Issue Number: close #18149
create table not support create empty name index

after parser PR: pingcap/parser/pull/1059
then update go.mod.

Problem Summary:

What is changed and how it works?

change token IndexName from ident to item type
use a NullIndexName struct to represent a empty index to distinguish from a anonymous index

Related changes

pingcap/parser

Check List

Tests

Unit test
go test -check.f TestValidator
go test -check.f TestCreateTable
Manual test (add detailed scripts or steps below)
In TiDB

mysql> CREATE TABLE t(x INT, KEY ``(x));
ERROR 1280 (42000): Incorrect index name '

In MySQL:

mysql> CREATE TABLE t1(x INT, KEY ``(x));
ERROR 1280 (42000): Incorrect index name ''

It has the same action with MySQL

Side effects

Release note

No release note.

watchpoints · 2020-10-24T05:08:14Z

@ti-srebot /run-all-tests

ti-srebot · 2020-10-24T05:08:17Z

/run-all-tests

xhebox

ddl_api.go changed its file permission from 644 to 755.

planner/core/preprocess_test.go

planner/core/preprocess.go

watchpoints · 2020-10-28T08:00:08Z

@tangenta , when runing make test int tidb with my parser,I get err:
tidb-server(PID: 129817) started

run all explain test cases
[2020/10/27 14:44:27.050 +08:00] [FATAL] [main.go:694] ["run test"] [test=select] [error="sql:sc;: run \"select !(1 + 2);\" at line 89 err Error 1105: Unknown Unary Op opcode.Op"] [errorVerbose="run \"select !(1 + 2);\" at line 89 err Error 1105: Unknown Unary Op opcode.Op\nmain.

(*tester).execute\n\t/root/code/src/github.com/watchpoints/tidb/cmd/explaintest/main.go:356\nmain.

but I run this sql , it is right.
select !(1 + 2);

…#20617)

tangenta · 2020-11-01T13:55:48Z

It is recommended to run make check before committing :)

ti-srebot · 2020-11-01T15:35:17Z

/run-make check

ti-srebot · 2020-11-01T15:36:26Z

/run-make check

watchpoints · 2020-11-01T15:37:45Z

@ti-srebot /run-all-tests

ti-srebot · 2020-11-01T15:37:47Z

/run-all-tests

tangenta · 2020-11-02T01:14:03Z

[2020-11-01T15:38:52.701Z] + GOPATH=/home/jenkins/agent/workspace/tidb_ghpr_check/go
[2020-11-01T15:38:52.701Z] + make check
[2020-11-01T15:38:52.701Z] gofmt (simplify)
[2020-11-01T15:39:48.903Z] cd tools/check; \
[2020-11-01T15:39:48.903Z] GO111MODULE=on go build -o ../bin/errcheck github.com/kisielk/errcheck
[2020-11-01T15:39:48.903Z] errcheck
[2020-11-01T15:39:58.910Z] cd tools/check; \
[2020-11-01T15:39:58.910Z] GO111MODULE=on go build -o ../bin/unconvert github.com/mdempsky/unconvert
[2020-11-01T15:39:58.910Z] unconvert check
[2020-11-01T15:41:07.428Z] cd tools/check; \
[2020-11-01T15:41:07.428Z] GO111MODULE=on go build -o ../bin/revive github.com/mgechev/revive
[2020-11-01T15:41:14.053Z] linting
[2020-11-01T15:41:24.026Z] go mod tidy
[2020-11-01T15:41:24.026Z] ./tools/check/check-tidy.sh
[2020-11-01T15:41:42.083Z] Files go.sum and /tmp/go.sum.before differ
[2020-11-01T15:41:42.083Z] make: *** [tidy] Error 1
script returned exit code 2

merge pingcap

watchpoints · 2020-11-02T12:12:35Z

[2020-11-01T15:38:52.701Z] + GOPATH=/home/jenkins/agent/workspace/tidb_ghpr_check/go
[2020-11-01T15:38:52.701Z] + make check
[2020-11-01T15:38:52.701Z] gofmt (simplify)
[2020-11-01T15:39:48.903Z] cd tools/check; \
[2020-11-01T15:39:48.903Z] GO111MODULE=on go build -o ../bin/errcheck github.com/kisielk/errcheck
[2020-11-01T15:39:48.903Z] errcheck
[2020-11-01T15:39:58.910Z] cd tools/check; \
[2020-11-01T15:39:58.910Z] GO111MODULE=on go build -o ../bin/unconvert github.com/mdempsky/unconvert
[2020-11-01T15:39:58.910Z] unconvert check
[2020-11-01T15:41:07.428Z] cd tools/check; \
[2020-11-01T15:41:07.428Z] GO111MODULE=on go build -o ../bin/revive github.com/mgechev/revive
[2020-11-01T15:41:14.053Z] linting
[2020-11-01T15:41:24.026Z] go mod tidy
[2020-11-01T15:41:24.026Z] ./tools/check/check-tidy.sh
[2020-11-01T15:41:42.083Z] Files go.sum and /tmp/go.sum.before differ
[2020-11-01T15:41:42.083Z] make: *** [tidy] Error 1
script returned exit code 2

go mod tidy
first run make check is right

**second run make check is wrong ,i not know why ?

Files go.sum and /tmp/go.sum.before differ**

i update tidb,now is

go: github.com/pingcap/tidb/_tools/util/timeutil imports
	github.com/uber-go/atomic: github.com/uber-go/atomic@v1.7.0: parsing go.mod:
	module declares its path as: go.uber.org/atomic
	        but was required as: github.com/uber-go/atomic

…#20617)

tangenta

LGTM

wjhuang2016

LGTM

bb7133

LGTM

bb7133 · 2020-11-03T04:19:38Z

/merge

ti-srebot · 2020-11-03T04:19:41Z

Your auto merge job has been accepted, waiting for:

20313
20122
20715
20715

ti-srebot · 2020-11-03T04:41:11Z

/run-all-tests

ti-challenge-bot · 2020-11-03T04:52:49Z

@watchpoints, Congratulations, you get 400 in this PR, and your total score is 400 in high-performance challenge program.

watchpoints added 7 commits October 22, 2020 15:53

DDL:not support create empty name index

39d73eb

DDL:not support create empty name index

74a0fd8

DDL:not support create empty name index

4c1b279

DDL:not support create empty name index

2a0e3fc

DDL:not support create empty name index

316cb12

DDL:not support create empty name index

88d8915

DDL:not support create empty name index

a4acaf7

watchpoints requested a review from a team as a code owner October 24, 2020 05:01

watchpoints requested review from XuHuaiyu and removed request for a team October 24, 2020 05:01

ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 24, 2020

DDL:not support create empty name index

81c2a26

github-actions bot added the sig/sql-infra SIG: SQL Infra label Oct 24, 2020

watchpoints closed this Oct 24, 2020

watchpoints reopened this Oct 24, 2020

watchpoints closed this Oct 24, 2020

watchpoints reopened this Oct 24, 2020

watchpoints closed this Oct 24, 2020

watchpoints reopened this Oct 24, 2020

xhebox requested changes Oct 24, 2020

View reviewed changes

bb7133 reviewed Oct 25, 2020

View reviewed changes

planner/core/preprocess_test.go Outdated Show resolved Hide resolved

bb7133 changed the title ~~DDL: createtable not support empty name index~~ DDL: create table should not allow explicit empty name index Oct 25, 2020

watchpoints added 2 commits October 25, 2020 16:57

DDL:not support create empty name index

aecc986

DDL: create table should not allow explicit empty name index

b9ceccb

XuHuaiyu removed their request for review October 28, 2020 02:28

tangenta reviewed Oct 28, 2020

View reviewed changes

planner/core/preprocess.go Outdated Show resolved Hide resolved

DDL: create table should not allow explicit empty name index

c76ac31

watchpoints added 3 commits November 1, 2020 20:29

DDL: create table should not allow explicit empty name index (pingcap…

f5e8be7

…#20617)

Merge branch 'dev_study' of github.com:watchpoints/tidb into dev_study

3373395

DDL: create table should not allow explicit empty name index (pingcap…

7bbfeea

…#20617)

Merge remote-tracking branch 'upstream/master' into dev_study

9f409ef

merge pingcap

DDL: create table should not allow explicit empty name index (pingcap…

2be13ba

…#20617)

tangenta reviewed Nov 3, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2020

wjhuang2016 reviewed Nov 3, 2020

View reviewed changes

ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2020

ti-srebot approved these changes Nov 3, 2020

View reviewed changes

ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 3, 2020

wjhuang2016 added the type/bug-fix This PR fixes a bug. label Nov 3, 2020

Merge branch 'master' into dev_study

2cdb385

bb7133 approved these changes Nov 3, 2020

View reviewed changes

ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 3, 2020

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2020

Merge branch 'master' into dev_study

d3f73ce

ti-srebot merged commit 3b4ba35 into pingcap:master Nov 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DDL: create table should not allow explicit empty name index #20617

DDL: create table should not allow explicit empty name index #20617

watchpoints commented Oct 24, 2020

watchpoints commented Oct 24, 2020

ti-srebot commented Oct 24, 2020

xhebox left a comment

watchpoints commented Oct 28, 2020 •

edited

tangenta commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

watchpoints commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

tangenta commented Nov 2, 2020 •

edited

watchpoints commented Nov 2, 2020

tangenta left a comment

wjhuang2016 left a comment

bb7133 left a comment

bb7133 commented Nov 3, 2020

ti-srebot commented Nov 3, 2020

ti-srebot commented Nov 3, 2020

ti-challenge-bot bot commented Nov 3, 2020

DDL: create table should not allow explicit empty name index #20617

DDL: create table should not allow explicit empty name index #20617

Conversation

watchpoints commented Oct 24, 2020

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

watchpoints commented Oct 24, 2020

ti-srebot commented Oct 24, 2020

xhebox left a comment

Choose a reason for hiding this comment

watchpoints commented Oct 28, 2020 • edited

tangenta commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

watchpoints commented Nov 1, 2020

ti-srebot commented Nov 1, 2020

tangenta commented Nov 2, 2020 • edited

watchpoints commented Nov 2, 2020

tangenta left a comment

Choose a reason for hiding this comment

wjhuang2016 left a comment

Choose a reason for hiding this comment

bb7133 left a comment

Choose a reason for hiding this comment

bb7133 commented Nov 3, 2020

ti-srebot commented Nov 3, 2020

ti-srebot commented Nov 3, 2020

ti-challenge-bot bot commented Nov 3, 2020

watchpoints commented Oct 28, 2020 •

edited

tangenta commented Nov 2, 2020 •

edited