driver.go & interpreter: remove driver.go and interpreter.go #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-and-interpreter Conflicts: ddl/ddl_db_test.go �:q!
|
LGTM |
zimulala
reviewed
Nov 23, 2016
| c.FailNow() | ||
| _, err := s.tk.Exec("insert into t2 values (?, ?, ?)", i, i, i) | ||
| if err != nil { | ||
| // if err is failed, the column number must be 4 now. |
There was a problem hiding this comment.
Line 577-584 don't need to be modified.
| @@ -465,7 +462,7 @@ func (s *testDBSuite) testAddColumn(c *C) { | |||
| num := defaultBatchSize + 10 | |||
| // add some rows | |||
| for i := 0; i < num; i++ { | |||
| s.mustExec(c, "insert into t2 values (?, ?, ?)", i, i, i) | |||
| s.tk.MustExec("insert into t2 values (?, ?, ?)", i, i, i) | |||
There was a problem hiding this comment.
You updated mustExec already, so you need not to modify here.
| tx := mustBegin(c, currDB) | ||
| r, err := tx.Query(s) | ||
| func newSession(c *C, store kv.Storage, dbName string) tidb.Session { | ||
| se, err := tidb.CreateSession(store) |
coocood
reviewed
Nov 23, 2016
| @@ -21,10 +21,12 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| _ "github.com/go-sql-driver/mysql" | |||
There was a problem hiding this comment.
We don't need to import mysql driver.
XuHuaiyu
force-pushed
the
xhy/remove-driver-and-interpreter
branch
from
a5eafc7
to
fb7f806
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
PTAL @coocood @shenli @zimulala @hanfei1991