Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update the errors dependence to the latest version #20917

Merged
merged 6 commits into from
Nov 10, 2020
Merged

*: update the errors dependence to the latest version #20917

merged 6 commits into from
Nov 10, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Nov 9, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

The PR pingcap/tiup#867 introduces functions that will merge the workaround/description from errors.toml with the error message from the repository. Make sure there are no conflicts between code and error metafile, the PR pingcap/errors#31 remove workaround/description options.

What is changed and how it works?

Update the errors/parser dependencies and fix some compilation errors.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng requested review from a team as code owners November 9, 2020 02:49
@lonng lonng requested review from lzmhhh123 and removed request for a team November 9, 2020 02:49
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2020

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2020

@lonng lonng changed the title Update the errors dependence to the latest version *: update the errors dependence to the latest version Nov 9, 2020
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 9, 2020
@lonng
Copy link
Contributor Author

lonng commented Nov 9, 2020

/merge

@ti-srebot
Copy link
Contributor

@lonng Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: execution(slack),ddl(slack).

@djshow832
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Nov 9, 2020

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Nov 9, 2020

/run-unit-test

@djshow832
Copy link
Contributor

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Nov 9, 2020

/run-unit-test

@lonng
Copy link
Contributor Author

lonng commented Nov 10, 2020

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Nov 10, 2020

/run-check_dev_2
/run-tics-test

@lonng
Copy link
Contributor Author

lonng commented Nov 10, 2020

/run-unit-test

@lonng lonng merged commit 8d35f17 into pingcap:master Nov 10, 2020
@lonng lonng deleted the update-errors branch November 10, 2020 01:50
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants