Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, expression: fix a bug causes schema change after DML (#21027) #21050

Merged
merged 3 commits into from Nov 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21027 to release-4.0


Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #19701

Problem Summary:
schema change after DML

What is changed and how it works?

Copy the fieldType

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fix a bug causes schema change after DML

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@you06
Copy link
Contributor

you06 commented Nov 13, 2020

/cherry-pick-invite

1 similar comment
@you06
Copy link
Contributor

you06 commented Nov 13, 2020

/cherry-pick-invite

@ti-srebot
Copy link
Contributor Author

@you06 you're already a collaborator in bot's repo.

@you06
Copy link
Contributor

you06 commented Nov 13, 2020

/cherry-pick-invite

@ti-srebot
Copy link
Contributor Author

@you06 you're already a collaborator in bot's repo.

@you06
Copy link
Contributor

you06 commented Nov 13, 2020

/cherry-pick-invite

@ti-srebot
Copy link
Contributor Author

@you06 please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
Copy link
Member

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21073
  • 21073
  • 21019
  • 21055
  • 20413
  • 21074
  • 21045

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 1e4def5 into pingcap:release-4.0 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants