ddl, planner: make partition table consider collation in create table and select sentence (#20937) #21181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/sql-infra
ti-srebot
requested review from
AilinKid,
bb7133,
hanfei1991,
tiancaiamao and
wjhuang2016
|
@xiongjiwei please accept the invitation then you can push to the cherry-pick pull requests. |
tiancaiamao
reviewed
Nov 21, 2020
ddl/partition.go
Outdated
| // TODO: Support multiple columns for 'PARTITION BY RANGE COLUMNS'. | ||
| if len(s.Partition.ColumnNames) != 1 { | ||
| pi.Enable = false | ||
| ctx.GetSessionVars().StmtCtx.AppendWarning(ErrUnsupportedPartitionByRangeColumns) | ||
| } | ||
| ======= |
There was a problem hiding this comment.
Please resolve conflicts
ti-srebot
added
status/LGT2
ti-srebot
added
status/LGT3
wjhuang2016
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20937 to release-4.0
What problem does this PR solve?
Issue Number: close #20879
Problem Summary:
partition table does not consider collation in
create tableandselectsentence.Check List
Tests
Release note
create tableandselectsentence.