Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core, session, sessionctx/variable: add session variable to control the concurrency of shuffle merge join #21332

Merged
merged 6 commits into from Nov 27, 2020
Merged

planner/core, session, sessionctx/variable: add session variable to control the concurrency of shuffle merge join #21332

merged 6 commits into from Nov 27, 2020

Conversation

huang-b
Copy link
Contributor

@huang-b huang-b commented Nov 26, 2020 •
edited by qw4990

What problem does this PR solve?

Problem Summary: The concurrency of shuffle merge join is hard coding.

What is changed and how it works?

Related to #14441.

What's Changed:

  1. In planner/core: Make the concurrency of shuffle merge join controlled by the variable MergeJoinConcurrency.
  2. In session and sessionctx/variable: Add new session variable mergeJoinConcurrency.

Release note

  • Add session variable to control the concurrency of shuffle merge join

@huang-b huang-b requested a review from a team as a code owner November 26, 2020 11:59
@huang-b huang-b requested review from SunRunAway and removed request for a team November 26, 2020 11:59
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@huang-b
Copy link
Contributor Author

huang-b commented Nov 26, 2020

/rebuild

@qw4990 qw4990 self-requested a review November 27, 2020 05:34
@qw4990
Copy link
Contributor

qw4990 commented Nov 27, 2020

/run-all-tests

qw4990
qw4990 reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2020
Reminiscent
Reminiscent approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 27, 2020
@Reminiscent
Copy link
Contributor

/can-merge

@qw4990 qw4990 merged commit cc0e1d4 into pingcap:master Nov 27, 2020
@huang-b huang-b deleted the dev_shuffle_merge_join branch November 27, 2020 06:09
@huang-b huang-b restored the dev_shuffle_merge_join branch November 28, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/executor status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@huang-b @sre-bot @qw4990 @Reminiscent @ti-srebot