Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/design: add design doc for pipelined window function execution #23028

Merged
merged 11 commits into from Oct 1, 2021
Merged

docs/design: add design doc for pipelined window function execution #23028

merged 11 commits into from Oct 1, 2021

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Mar 1, 2021 •
edited by tisonkun

This PR contains the design of #23022 .

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2021
Yisaer
Yisaer reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

docs/design/2021-03-01-pipelined-window-functions.md Show resolved Hide resolved
docs/design/2021-03-01-pipelined-window-functions.md Outdated Show resolved Hide resolved
@ichn-hu ichn-hu mentioned this pull request Apr 1, 2021
Closed
7 tasks
@ichn-hu
Copy link
Contributor Author

ichn-hu commented Apr 13, 2021

/run-all-tests

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Jul 16, 2021

@wshwsh12 @XuHuaiyu since the window function PR is already merged, let's also merge the design doc.

tisonkun and others added 2 commits September 17, 2021 10:35
@tisonkun
update implementation
4755af8 
Signed-off-by: tison <wander4096@gmail.com>
@ichn-hu
Merge branch 'master' into add-pw-dc
8cc0b98
tisonkun
tisonkun approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the implementation is already done and the content is clear, looks good to me.

I hope we can later propose first and later implement it.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2021
@tisonkun
Copy link
Contributor

/cc @XuHuaiyu @wshwsh12

PTAL.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 1, 2021
@Yisaer
Copy link
Contributor

Yisaer commented Oct 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cc0b98

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 1, 2021
@ti-chi-bot
Copy link
Member

@ichn-hu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 88baceb into pingcap:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@tisonkun tisonkun tisonkun approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ichn-hu @ti-chi-bot @tisonkun @Yisaer