Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: check partition definition with unsigned option #23428

Merged
merged 6 commits into from
Mar 23, 2021
Merged

partition: check partition definition with unsigned option #23428

merged 6 commits into from
Mar 23, 2021

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Mar 19, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23385

  • partition check does not consider the unsigned flag
  • overflow on int column can be ignored such as create table t(a tinyint) partition by range(a) (partition p0 values less than (1234567));

Check List

Tests

  • Unit test

Release note

  • fix invalid partition can create success

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 19, 2021
@xiongjiwei xiongjiwei closed this Mar 19, 2021
@xiongjiwei xiongjiwei reopened this Mar 19, 2021
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei xiongjiwei marked this pull request as ready for review March 19, 2021 07:22
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2021
@xiongjiwei
Copy link
Contributor Author

/cc @tiancaiamao @crazycs520

@zimulala
Copy link
Contributor

/cc @tiancaiamao @AilinKid @tangenta

@ti-chi-bot ti-chi-bot requested review from tangenta and removed request for crazycs520 March 23, 2021 02:02
@ti-chi-bot
Copy link
Member

@zimulala: GitHub didn't allow me to request PR reviews from the following users: AilinKid.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tiancaiamao @AilinKid @tangenta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala zimulala added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Mar 23, 2021
@xiongjiwei
Copy link
Contributor Author

/type bugfix

@ti-chi-bot
Copy link
Member

@xiongjiwei: The label(s) type/bugfix cannot be applied, because the repository doesn't have them.

In response to this:

/type bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xiongjiwei
Copy link
Contributor Author

/type bug-fix

@ti-chi-bot ti-chi-bot added the type/bug-fix This PR fixes a bug. label Mar 23, 2021
tangenta
tangenta reviewed Mar 23, 2021
View reviewed changes
ddl/partition.go Outdated Show resolved Hide resolved
@xiongjiwei @tangenta
Update ddl/partition.go
b0176e6 
Co-authored-by: tangenta <tangenta@126.com>
tangenta
tangenta reviewed Mar 23, 2021
View reviewed changes
ddl/error.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2021
@xiongjiwei @tangenta
Update ddl/error.go
3e4a07a 
Co-authored-by: tangenta <tangenta@126.com>
xhebox
xhebox approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@xhebox: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e4a07a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@ti-chi-bot ti-chi-bot merged commit 8c897b1 into pingcap:master Mar 23, 2021
@xiongjiwei
Copy link
Contributor Author

/run-cherry-pick

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#23428 to release-5.0
842cbd4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 failed

@xiongjiwei
Copy link
Contributor Author

/run-cherry-pick

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@xiongjiwei
partition: check partition definition with unsigned option (#23428) (#…
b18eae9 
…23505)
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@xiongjiwei @SabaPing
partition: check partition definition with unsigned option (pingcap#2…
17e7b44 
…3428)
@bb7133 bb7133 mentioned this pull request Aug 1, 2021
Closed
@xiongjiwei xiongjiwei deleted the partition-def branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@xhebox xhebox xhebox approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 priority/release-blocker This PR blocks a release. Please review it ASAP. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create partition table doesn't check the unsigned option
6 participants
@xiongjiwei @zimulala @ti-chi-bot @tangenta @xhebox @ti-srebot