Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: ignore all other locks except the first one met by autocommit point select #24070

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Apr 16, 2021

What is changed and how it works?

This PR reverts #22789. In addition, this PR makes point select with max ts ignore all locks except the first one.

The solution is to minimize changes done to the release-5.0 branch.
For the master branch, I think we can use a new protocol that brings the first lock's start_ts to reduce invalid retries.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Benchmark result:
图片

Release note

  • Fix performance regression of point select.

@sticnarf sticnarf added the sig/transaction SIG:Transaction label Apr 16, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Apr 16, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2021
@sticnarf sticnarf marked this pull request as ready for review April 16, 2021 08:01
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@sticnarf sticnarf requested a review from cfzjywxk April 16, 2021 08:04
@sticnarf sticnarf removed the sig/sql-infra SIG: SQL Infra label Apr 16, 2021
@cfzjywxk cfzjywxk added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Apr 16, 2021
@cfzjywxk cfzjywxk added this to the 5.0.1 milestone Apr 16, 2021
@cfzjywxk
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 16, 2021
@sticnarf
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2881d0d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot
Copy link
Member

@sticnarf: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 813bd92 into pingcap:release-5.0 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. priority/release-blocker This PR blocks a release. Please review it ASAP. sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants