Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "planner: donot prune all columns for Projection (#24024) (#24093)" #24202

Merged
merged 2 commits into from Apr 22, 2021
Merged

Revert "planner: donot prune all columns for Projection (#24024) (#24093)" #24202

merged 2 commits into from Apr 22, 2021

Conversation

guo-shaoge
Copy link
Collaborator

This reverts commit f5cac30.

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #24149

Problem Summary: This PR revert this commit . Because it cause case regression. The corresponding issue will be reopend, and will be fixed in next version.

What is changed and how it works?

What's Changed: revert code

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects: reopened issues will be fixed later.

Release note

  • No release note

@guo-shaoge
Revert "planner: donot prune all columns for Projection (pingcap#24024)…
476c6e4 
… (pingcap#24093)"

This reverts commit f5cac30.

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix case. (miss revert some case)
e8b94ef 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge guo-shaoge requested review from a team as code owners April 22, 2021 08:06
@guo-shaoge guo-shaoge requested review from qw4990 and hanfei1991 and removed request for a team April 22, 2021 08:06
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev

@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

1 similar comment
@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2021
@lzmhhh123
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8b94ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit 1145e34 into pingcap:release-5.0 Apr 22, 2021
@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-master

@ti-chi-bot
Copy link
Member

@guo-shaoge: The label(s) needs-cherry-pick-master cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0-rc, needs-cherry-pick-5.0, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label needs-cherry-pick-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced May 10, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guo-shaoge @ti-chi-bot @lzmhhh123 @winoros @zhouqiang-cl