store/copr: invalidate stale regions for Mpp query. (#24410) #24432
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
size/M
ti-chi-bot
removed
the
size/M
ti-chi-bot
added
the
size/XXL
|
@hanfei1991 you're already a collaborator in bot's repo. |
ti-chi-bot
added
size/S
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
store/copr/mpp.go
Outdated
| @@ -243,6 +243,13 @@ func (m *mppIterator) handleDispatchReq(ctx context.Context, bo *tikv.Backoffer, | |||
| m.sendError(errors.New(realResp.Error.Msg)) | |||
| return | |||
| } | |||
| if len(realResp.RetryRegions) > 0 { | |||
There was a problem hiding this comment.
It's unnecessary, I will fix it
|
/run-check_dev |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
zhouqiang-cl
added
backport-5.0.3
cherry-pick-approved
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 149e5a8
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
/merge |
cherry-pick #24410 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24432After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Right now, we won't update the stale regions during executing Mpp queries. Then we added the try regions field in MppDispatchTask reponse. In this pr, we try to invalidate the stale regions in the mppr response.
What is changed and how it works?
Related changes
pingcap/kvproto#751
Check List
Tests
["DAGQueryBlockInterpreter: Start to retry 1 regions (10936,)"]["invalid region because tiflash detected stale region"] ["region id"="{ region id: 10936, ver: 116, confVer: 2 }"]proving this function works.Release note