*: change SHOW CONFIG to require CONFIG privilege

[morgo]

What problem does this PR solve?

Problem Summary:

The original design document for SEM specified that SHOW CONFIG would be disabled, but SET CONFIG is still permitted with the config privilege. From further discussion, this is a weird behavior, since SET CONFIG is not useful when SHOW CONFIG is disabled.

Since it is desired that SHOW CONFIG is hidden from lower privileged users, the next discussion topic is what permission should it require? Since SET CONFIG requires the CONFIG privilege, the natural conclusion is that SHOW CONFIG should also.

This PR makes this change to the privileges, and updates the original proposal.

What is changed and how it works?

What's Changed:

The SHOW CONFIG statement now requires the CONFIG privileges to be assigned.

Related changes

• None

Check List

Tests

• Unit test
• Integration test

Side effects

• Breaking backward compatibility (not expected to be a major use-case broken, but it is still a compatibility change)

Release note

• The SHOW CONFIG statement now requires the CONFIG privileges to be assigned.

[morgo]

/run-check_dev_2

[bb7133]

/lgtm

[ti-chi-bot]

@bb7133: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

Since it is a compatibility breaker, we need to update the document accordingly.

[bb7133]

PTAL @tiancaiamao @djshow832

[morgo]

Since it is a compatibility breaker, we need to update the document accordingly.

Did you mean release notes, or something specific like SHOW CONFIG docs?

[bb7133]

Since it is a compatibility breaker, we need to update the document accordingly.

Did you mean release notes, or something specific like SHOW CONFIG docs?

I think we need to do the both, and explicitly announce that this compatibility change in the release note.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• djshow832
• tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[tiancaiamao]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 230fe4c

[zhouqiang-cl]

/rebuild

[bb7133]

/merge

[ti-srebot]

cherry pick to release-5.1 in PR #25433