Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: [cherry-pick-5.0] support push fucntions down to TiFlash: unix_timestamp,concat,year,day,datediff,datesub,castTimeAsString,concat_ws. #25564

Merged
merged 3 commits into from
Jun 18, 2021
Merged

expression: [cherry-pick-5.0] support push fucntions down to TiFlash: unix_timestamp,concat,year,day,datediff,datesub,castTimeAsString,concat_ws. #25564

merged 3 commits into from
Jun 18, 2021

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: cherry-pick #25097 , #25083

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Support push fucntion unix_timestamp,concat,year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash.

@LittleFall LittleFall requested a review from a team as a code owner June 18, 2021 07:51
@LittleFall LittleFall requested review from qw4990 and removed request for a team June 18, 2021 07:51
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2021
This was referenced Jun 18, 2021
Closed
Closed
leiysky
leiysky approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leiysky
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

@zhouqiang-cl zhouqiang-cl added backport-5.0.3 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 18, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5c873e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot
Copy link
Member

@LittleFall: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall
Copy link
Contributor Author

@ti-chi-bot

@LittleFall
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit eb9b926 into pingcap:release-5.0 Jun 18, 2021
@LittleFall LittleFall deleted the cherrypick/functions branch June 18, 2021 11:09
@zhouqiang-cl zhouqiang-cl added this to the v5.0.3 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@leiysky leiysky leiysky approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LittleFall @ti-chi-bot @xiongjiwei @leiysky @lzmhhh123 @zhouqiang-cl