Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Improve the compatibility of str_to_date (#25386) #25767

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 25, 2021

cherry-pick #25386 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25767

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25767:release-5.0-8434069c5f63

What problem does this PR solve?

Issue Number: related to #24928

Problem Summary:

  • '%b'/'%M' should be case insensitive
  • Improve the compatibility of parsing some input for "%r" and "%T"

What is changed and how it works?

  • Use strings.EqualFold for case insensitive prefix comparing in fullNameMonth
  • Make abbreviatedMonth case insensitive
  • Make time12Hour and time24Hour accept some irregular inputs

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
  • Breaking backward compatibility

Release note

  • Improve the MySQL compatibility of str_to_date for %b/%M/%r/%T

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner June 25, 2021 11:28
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team June 25, 2021 11:28
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/expression size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 25, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 25, 2021
@ti-srebot
Copy link
Contributor Author

@JaySon-Huang you're already a collaborator in bot's repo.

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@JaySon-Huang
Copy link
Contributor

/run-check_dev

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 25, 2021

[2021-06-25T12:09:05.702Z] ./tools/check/check_testSuite.sh
[2021-06-25T12:09:07.604Z] tools/bin/golangci-lint run -v --disable-all --deadline=3m \
[2021-06-25T12:09:07.604Z]   --enable=misspell \
[2021-06-25T12:09:07.604Z]   --enable=ineffassign \
[2021-06-25T12:09:07.604Z]   --enable=varcheck \
...
[2021-06-25T12:09:19.085Z] level=info msg="[runner] linters took 5.641386383s with stages: goanalysis_metalinter: 5.626532342s"
[2021-06-25T12:09:19.085Z] types/time.go:3017:3: ineffectual assignment to `state` (ineffassign)
[2021-06-25T12:09:19.085Z] 		state := parseStateNormal
[2021-06-25T12:09:19.085Z] 		^
[2021-06-25T12:09:19.085Z] types/time.go:3095:3: ineffectual assignment to `state` (ineffassign)
[2021-06-25T12:09:19.085Z] 		state := parseStateNormal
[2021-06-25T12:09:19.085Z] 		^

Why this lint check didn't apply to the master branch?

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor

@wshwsh12 @guo-shaoge @wjhuang2016 PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 28, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2a33192

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c8b2f25 into pingcap:release-5.0 Jun 28, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-8434069c5f63 branch June 28, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants