Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: stop DDL retry when partition ID is not found in truncate partition #26232

Merged
merged 3 commits into from
Jul 14, 2021
Merged

ddl: stop DDL retry when partition ID is not found in truncate partition #26232

merged 3 commits into from
Jul 14, 2021

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 14, 2021 •
edited by AilinKid

What problem does this PR solve?

Issue Number: close #26229

Problem Summary:

Before this PR, TRUNCATE PARTITION DDL job use partition ID as the job argument.

Since the truncating implementation is to drop old partition and then add a new partition, the partition ID is changed between two
job. However, it is possible that there are 2 same "truncate" job occurs in the DDL job queue, because they are enqueued by different TiDB server.

In this case, the argument(partition ID) of the second job becomes invalid. Finally the error 'partition not found' is reported.

What is changed and how it works?

What's Changed: Use partition name instead of ID as the job argument.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more Memory

Documentation

NA

Release note

  • Fix the issue that concurrently truncating the same partition hangs DDL.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2021
@tangenta tangenta added the sig/sql-infra SIG: SQL Infra label Jul 14, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2021
@AilinKid
Copy link
Contributor

potential risk is that:
truncate partition / truncated partition ...
when some dml succeed when ddl 1 is finished, it will be lost when ddl 2 is finished.

@tangenta tangenta changed the title ddl: use partition name instead of ID as the truncate partition job argument ddl: stop DDL retry when partition ID is not found in truncate partition Jul 14, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2021
AilinKid
AilinKid reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b1bba5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@ti-chi-bot ti-chi-bot merged commit 1ecae3d into pingcap:master Jul 14, 2021
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2021
Merged
3 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 14, 2021
@ti-srebot
cherry pick pingcap#26232 to release-4.0
deeea24 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26237

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 14, 2021
@ti-srebot
cherry pick pingcap#26232 to release-5.0
cbb5560 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2021
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26238

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 14, 2021
@ti-srebot
cherry pick pingcap#26232 to release-5.1
08099a9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 14, 2021
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26239

ti-chi-bot pushed a commit that referenced this pull request Jul 22, 2021
@ti-srebot
ddl: stop DDL retry when partition ID is not found in `truncate parti…
68070cb 
…tion` (#26232) (#26239)
ti-chi-bot pushed a commit that referenced this pull request Sep 2, 2021
@ti-srebot
ddl: stop DDL retry when partition ID is not found in `truncate parti…
0a18ae2 
…tion` (#26232) (#26238)
ti-chi-bot pushed a commit that referenced this pull request Nov 24, 2021
@ti-srebot
ddl: stop DDL retry when partition ID is not found in `truncate parti…
f3ed8ea 
…tion` (#26232) (#26237)
@time-and-fate time-and-fate mentioned this pull request Jul 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

concurrently truncating the same partition hangs DDL
5 participants
@tangenta @AilinKid @ti-chi-bot @ti-srebot @crazycs520