-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: stop DDL retry when partition ID is not found in truncate partition
#26232
Conversation
potential risk is that: |
truncate partition
job argumenttruncate partition
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2b1bba5
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #26237 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #26238 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #26239 |
What problem does this PR solve?
Issue Number: close #26229
Problem Summary:
Before this PR,
TRUNCATE PARTITION
DDL job use partition ID as the job argument.Since the truncating implementation is to drop old partition and then add a new partition, the partition ID is changed between two
job. However, it is possible that there are 2 same "truncate" job occurs in the DDL job queue, because they are enqueued by different TiDB server.
In this case, the argument(partition ID) of the second job becomes invalid. Finally the error 'partition not found' is reported.
What is changed and how it works?
What's Changed: Use partition name instead of ID as the job argument.
Check List
Tests
Side effects
Documentation
NA
Release note