Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: start a goroutine to consume task channel if errorred. #2678

Merged
merged 2 commits into from Feb 20, 2017
Merged

executor: start a goroutine to consume task channel if errorred. #2678

merged 2 commits into from Feb 20, 2017

Conversation

coocood
Copy link
Member

@coocood coocood commented Feb 19, 2017 •
edited

In theroy, reduce the goroutine leak possibility.

@tiancaiamao
Copy link
Contributor

LGTM

BTW, with this change, it just handle release the resource safely.
A better way to do it is to cancel the execution, which not only release resource, but also avoid unnecessary computation.

I'll do some tiny refact after #2636

@shenli
Copy link
Member

shenli commented Feb 20, 2017

LGTM

@coocood coocood merged commit fd9744c into master Feb 20, 2017
@coocood coocood deleted the coocood/fix-gouroutine-leak branch February 20, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coocood @tiancaiamao @shenli