expression/expressions: replace iconv-go with text/transform #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove CGO requirement for compiling iconv-go currently is using. Replace it with native implmentation of Go. Signed-off-by: Unknwon <u@gogs.io>
Signed-off-by: Unknwon <u@gogs.io>
|
OK... I don't get the error here: https://travis-ci.org/pingcap/tidb/jobs/79013804 What did I miss? |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* add restrict in restore table and dbs * fix test * fix dead lock * address comment * address comment
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jan 8, 2022
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Apr 11, 2022
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: disksing <i@disksing.com> Signed-off-by: disksing <i@disksing.com> Co-authored-by: Yuqing Bai <baiyuq@gmail.com>
BornChanger
added a commit
to BornChanger/tidb
that referenced
this pull request
Dec 6, 2022
…ingcap#27) Signed-off-by: BornChanger <dawn_catcher@126.com>
Connor1996
pushed a commit
to Connor1996/tidb
that referenced
this pull request
Dec 14, 2022
…ingcap#27) * *: pass user's resource group naem to sessionVars.ResourceGroupName Signed-off-by: BornChanger <dawn_catcher@126.com>
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…48742) (pingcap#27) close pingcap#48629 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove CGO requirement for compiling iconv-go currently is using.
Replace it with native implmentation of Go.
Signed-off-by: Unknwon u@gogs.io
maketest has passed, but test cases don't look very detailed onexpression, so not sure if everything will go well.Godep really kills the diff page. 😂