Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support plan replayer load #29247

Merged
merged 14 commits into from Nov 1, 2021
Merged

*: support plan replayer load #29247

merged 14 commits into from Nov 1, 2021

Conversation

rebelice
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #29246

Problem Summary:

support plan replayer load

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 29, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2021
Yisaer
Yisaer reviewed Oct 29, 2021
View reviewed changes
executor/builder.go Outdated
Comment on lines 912 to 913
baseExecutor: newBaseExecutor(b.ctx, nil, v.ID()),
info: &PlanReplayerLoadInfo{Path: v.File, Ctx: b.ctx},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hold b.ctx twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlanReplayerLoadInfo will use Ctx when alone. You can see handlePlanReplayerLoad for details.

executor/plan_replayer.go Outdated Show resolved Hide resolved
executor/plan_replayer.go Outdated
return errors.New("plan replayer: create schema and tables failed")
}
// create database
_, err = ctx.(sqlexec.SQLExecutor).Execute(context.TODO(), sqls[0])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use sessioncontext's ctx instead of context.TODO()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the meanings of the two are different. Refer to other usage methods, I think it is more appropriate to use context.Background(). Updated.

rebelice and others added 3 commits October 29, 2021 18:48
@rebelice
add test and fmt
70e9218
@rebelice @Yisaer
Update executor/plan_replayer.go
79a0f39 
Co-authored-by: Song Gao <disxiaofei@163.com>
@rebelice
fix ci
66549a0
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a53897a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@ti-chi-bot
Copy link
Member

@rebelice: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rebelice
Copy link
Contributor Author

rebelice commented Nov 1, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 2c69740 into pingcap:master Nov 1, 2021
@bb7133 bb7133 mentioned this pull request Dec 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support plan replayer load
4 participants
@rebelice @ti-chi-bot @qw4990 @Yisaer