Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Add a design doc for integer shard index #31260

Merged
merged 7 commits into from Mar 2, 2022
Merged

Doc: Add a design doc for integer shard index #31260

merged 7 commits into from Mar 2, 2022

Conversation

TonsnakeLin
Copy link
Contributor

@TonsnakeLin TonsnakeLin commented Jan 4, 2022 •
edited

Signed-off-by: TonsnakeLin lpbgytong@163.com

What problem does this PR solve?

Issue Number: close #31040

Problem Summary:
Add a design document for shard index feature whose PR is #30659

What is changed and how it works?

Check List

Release note

None

@TonsnakeLin
Add a design doc for integer shard index
fc9d585 
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@TonsnakeLin
Copy link
Contributor Author

@youjiali1995 @cfzjywxk @you06
PTAL, thanks!

@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/58f92ca617f1eed7eab41ddd2566558a79290b49

@TonsnakeLin TonsnakeLin changed the title Add a design doc for integer shard index Doc: Add a design doc for integer shard index Jan 4, 2022
@TonsnakeLin
Copy link
Contributor Author

/run-check_title

@TonsnakeLin
Copy link
Contributor Author

/run-check_dev

@TonsnakeLin
modify design doc for integer shard index
f768cb7 
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2022
@TonsnakeLin
Copy link
Contributor Author

/run-unit-test

2 similar comments
@TonsnakeLin
Copy link
Contributor Author

/run-unit-test

@TonsnakeLin
Copy link
Contributor Author

/run-unit-test

cfzjywxk
cfzjywxk reviewed Jan 20, 2022
View reviewed changes
docs/design/2022-01-04-integer-shard-index.md Outdated Show resolved Hide resolved
docs/design/2022-01-04-integer-shard-index.md Outdated Show resolved Hide resolved
docs/design/2022-01-04-integer-shard-index.md Show resolved Hide resolved
docs/design/2022-01-04-integer-shard-index.md Show resolved Hide resolved
docs/design/2022-01-04-integer-shard-index.md Outdated

## Questions

As I know @tiancaiamao is intended to do the shard index more comprehensively.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there're links we could add them here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mentioned in his OKR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a referencing document we could link it here, by now seems there's no detailed design yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it

@TonsnakeLin
fix by some review advice
e9292d7 
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@TonsnakeLin
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@TonsnakeLin
Copy link
Contributor Author

/run-check_dev_2

cfzjywxk
cfzjywxk approved these changes Mar 1, 2022
View reviewed changes
docs/design/2022-01-04-integer-shard-index.md Outdated Show resolved Hide resolved
docs/design/2022-01-04-integer-shard-index.md Outdated

## Questions

As I know @tiancaiamao is intended to do the shard index more comprehensively.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a referencing document we could link it here, by now seems there's no detailed design yet.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@TonsnakeLin
Copy link
Contributor Author

/run-unit-test

@TonsnakeLin
fix by some review advice
eb35929 
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@TonsnakeLin
Copy link
Contributor Author

/run-check_dev_2

2 similar comments
@TonsnakeLin
Copy link
Contributor Author

/run-check_dev_2

@TonsnakeLin
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb35929

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@ti-chi-bot ti-chi-bot merged commit 9f4dd6d into pingcap:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@winoros winoros Awaiting requested review from winoros

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using shard index to scatter integer hot index
6 participants
@TonsnakeLin @ti-chi-bot @sre-bot @youjiali1995 @cfzjywxk @tangenta