ddl: improve test to avoid cycle import

[hawkingrei]

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: ref #31716

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• rebelice
• wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[hawkingrei]

/run-unit-test

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/95db553c7fe51fc120151b8a19af69828c43010f

[hawkingrei]

/run-unit-test

[rebelice]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 927b14f

[ti-chi-bot]

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[tisonkun]

Could you please describe how moving out these methods resolve cycle import?

IMO it's quite a bit clumsy now to write GetTableByName(t, tk, ...) instead of tk.GetTableByName(...).

Also, this PR is blank to describe the background and motivation to make a non-trivial change. It confuses.

[hawkingrei]

We have a feature branch and add some test cases. but we find some import cycles when adding test cases for example domain, table, and so on. so we think we should add less dependency in the testkit pkg. and put more dependency into other package.