server: Improve compatibility with MySQL 5.5 and 5.6 clients #32338

dveeden · 2022-02-14T14:18:34Z

What problem does this PR solve?

Issue Number: close #32334

Problem Summary:

With a MySQL 5.5 or MySQL 5.6 client connecting to an account in TiDB that uses mysql_native_password,
as authentication plugin but doesn't have a password set results in connection failures.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Compatibility with MySQL 5.5 and MySQL 5.6 and passwordless accounts was improved.

ti-chi-bot · 2022-02-14T14:18:35Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

mjonss
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

dveeden · 2022-02-14T14:50:21Z

/cc @morgo @mjonss @seiya-annie

dveeden · 2022-02-14T14:53:51Z

/label affects-5.4

sre-bot · 2022-02-14T15:00:04Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/178ad0487e2a007efb36dbdf4bd5cdbb04b8183a

dveeden · 2022-02-14T15:02:48Z

Without this PR

TiDB Client Test
Connected to:
	Release Version: v5.5.0-alpha-326-g2d9394421
	Edition: Community
	Git Commit Hash: 2d93944210c460dacce66900de21b23c838092fb
	Git Branch: master
	UTC Build Time: 2022-02-14 15:00:40
	GoVersion: go1.16.13
	Race Enabled: false
	TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
	Check Table Before Drop: false
Clients:
	/home/dvaneeden/opt/mysql/5.1.73/bin/mysql
	/home/dvaneeden/opt/mysql/5.5.62/bin/mysql
	/home/dvaneeden/opt/mysql/5.6.44/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.31/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.36/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.22/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.25/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.26/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.27/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.28/bin/mysql
-----------------------------------------------
Test results for test with mysql_native_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.6.44  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅
-----------------------------------------------
❌	  Command '/home/dvaneeden/opt/mysql/5.5.62/bin/mysql -u nopw -h 127.0.0.1 -P 4000 -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.5.62/bin/mysql -u nopw -S /tmp/tidb.sock -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.5.62/bin/mysql -u socket -S /tmp/tidb.sock -pdvaneeden -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.6.44/bin/mysql -u nopw -h 127.0.0.1 -P 4000 -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.6.44/bin/mysql -u nopw -S /tmp/tidb.sock -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.6.44/bin/mysql -u socket -S /tmp/tidb.sock -pdvaneeden -e QUIT' returned 1.
Warning: Using a password on the command line interface can be insecure.
ERROR 2012 (HY000): Error in server handshake

Test results for test with caching_sha2_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	❌	❌	✅	✅	✔️	✔️	✔️	❌
5.6.44  	❌	❌	✅	✅	✔️	✔️	✔️	❌
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅

With this PR

TiDB Client Test
Connected to:
	Release Version: v5.5.0-alpha-328-g416b3ed1e
	Edition: Community
	Git Commit Hash: 416b3ed1ebf5ee70b717f7f6e658d89efd52e08e
	Git Branch: old_nopw_client
	UTC Build Time: 2022-02-14 15:02:08
	GoVersion: go1.16.13
	Race Enabled: false
	TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
	Check Table Before Drop: false
Clients:
	/home/dvaneeden/opt/mysql/5.1.73/bin/mysql
	/home/dvaneeden/opt/mysql/5.5.62/bin/mysql
	/home/dvaneeden/opt/mysql/5.6.44/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.31/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.36/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.22/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.25/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.26/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.27/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.28/bin/mysql
-----------------------------------------------
Test results for test with mysql_native_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.6.44  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅
-----------------------------------------------
❌	  Command '/home/dvaneeden/opt/mysql/5.5.62/bin/mysql -u socket -S /tmp/tidb.sock -pdvaneeden -e QUIT' returned 1.
ERROR 2012 (HY000): Error in server handshake

❌	  Command '/home/dvaneeden/opt/mysql/5.6.44/bin/mysql -u socket -S /tmp/tidb.sock -pdvaneeden -e QUIT' returned 1.
Warning: Using a password on the command line interface can be insecure.
ERROR 2012 (HY000): Error in server handshake

Test results for test with caching_sha2_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	✅	✅	✅	✅	✔️	✔️	✔️	❌
5.6.44  	✅	✅	✅	✅	✔️	✔️	✔️	❌
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅

(from https://github.com/dveeden/tidb_client_test @ 47064e5426a60ada71436d6462d9a5e924dc7a40 )

mjonss

LGTM

ti-chi-bot · 2022-02-15T02:01:04Z

@seiya-annie: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This is for clients connecting over a UNIX domain socket to a server with `caching_sha2_password` as default auth. Test from https://github.com/dveeden/tidb_client_test v0.0.1 ``` TiDB Client Test Connected to: Release Version: v5.5.0-alpha-374-gc55ff5018 Edition: Community Git Commit Hash: c55ff5018c9027e50cc3d55b863c2e7902d4e848 Git Branch: old_nopw_client UTC Build Time: 2022-02-18 14:39:04 GoVersion: go1.18rc1 Race Enabled: false TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306 Check Table Before Drop: false Clients: /home/dvaneeden/opt/mysql/5.1.73/bin/mysql /home/dvaneeden/opt/mysql/5.5.62/bin/mysql /home/dvaneeden/opt/mysql/5.6.44/bin/mysql /home/dvaneeden/opt/mysql/5.7.31/bin/mysql /home/dvaneeden/opt/mysql/5.7.36/bin/mysql /home/dvaneeden/opt/mysql/8.0.22/bin/mysql /home/dvaneeden/opt/mysql/8.0.25/bin/mysql /home/dvaneeden/opt/mysql/8.0.26/bin/mysql /home/dvaneeden/opt/mysql/8.0.27/bin/mysql /home/dvaneeden/opt/mysql/8.0.28/bin/mysql ----------------------------------------------- Test results for test with mysql_native_password as default authentication format auth native native native native sha2 sha2 socket socket user nopw nopw native native sha2 sha2 socket socket connection TCP socket TCP socket TCP socket TCP socket 5.1.73 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✔️ 5.5.62 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✅ 5.6.44 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✅ 5.7.31 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 5.7.36 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.22 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.25 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.26 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.27 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.28 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ ----------------------------------------------- Test results for test with caching_sha2_password as default authentication format auth native native native native sha2 sha2 socket socket user nopw nopw native native sha2 sha2 socket socket connection TCP socket TCP socket TCP socket TCP socket 5.1.73 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✔️ 5.5.62 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✅ 5.6.44 ✅ ✅ ✅ ✅ ✔️ ✔️ ✔️ ✅ 5.7.31 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 5.7.36 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.22 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.25 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.26 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.27 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ 8.0.28 ✅ ✅ ✅ ✅ ✅ ✅ ✔️ ✅ ``` I created and used https://github.com/dveeden/sock_debug to troubleshoot this.

dveeden · 2022-02-18T14:48:05Z

With my latest commit added:

TiDB Client Test
Connected to:
	Release Version: v5.5.0-alpha-374-gc55ff5018
	Edition: Community
	Git Commit Hash: c55ff5018c9027e50cc3d55b863c2e7902d4e848
	Git Branch: old_nopw_client
	UTC Build Time: 2022-02-18 14:39:04
	GoVersion: go1.18rc1
	Race Enabled: false
	TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
	Check Table Before Drop: false
Clients:
	/home/dvaneeden/opt/mysql/5.1.73/bin/mysql
	/home/dvaneeden/opt/mysql/5.5.62/bin/mysql
	/home/dvaneeden/opt/mysql/5.6.44/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.31/bin/mysql
	/home/dvaneeden/opt/mysql/5.7.36/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.22/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.25/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.26/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.27/bin/mysql
	/home/dvaneeden/opt/mysql/8.0.28/bin/mysql
-----------------------------------------------
Test results for test with mysql_native_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.6.44  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅
-----------------------------------------------
Test results for test with caching_sha2_password as default authentication format
auth    	native	native	native	native	sha2	sha2	socket	socket
user    	nopw	nopw	native	native	sha2	sha2	socket	socket
connection	TCP	socket	TCP	socket	TCP	socket	TCP	socket
5.1.73  	✅	✅	✅	✅	✔️	✔️	✔️	✔️
5.5.62  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.6.44  	✅	✅	✅	✅	✔️	✔️	✔️	✅
5.7.31  	✅	✅	✅	✅	✅	✅	✔️	✅
5.7.36  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.22  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.25  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.26  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.27  	✅	✅	✅	✅	✅	✅	✔️	✅
8.0.28  	✅	✅	✅	✅	✅	✅	✔️	✅

hawkingrei · 2022-02-18T15:12:18Z

Have some error in the linter. Please fix it.

…check)'

hawkingrei · 2022-02-18T16:20:24Z

/run-mysql-test

zimulala · 2022-03-03T07:05:14Z

/merge

ti-chi-bot · 2022-03-03T07:05:17Z

This pull request has been accepted and is ready to merge.

Commit hash: 3fa1d02

…ingcap#32338)" This reverts commit 7e8ca4c.

ti-chi-bot added release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2022

dveeden marked this pull request as draft February 14, 2022 14:18

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2022

dveeden force-pushed the old_nopw_client branch from 34d0aa4 to 67bed88 Compare February 14, 2022 14:47

server: Improve compatibility with MySQL 5.5 and 5.6 clients

50f3bfb

dveeden force-pushed the old_nopw_client branch from 67bed88 to 50f3bfb Compare February 14, 2022 14:48

dveeden marked this pull request as ready for review February 14, 2022 14:48

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2022

ti-chi-bot requested review from mjonss, morgo and seiya-annie February 14, 2022 14:50

Merge branch 'master' into old_nopw_client

416b3ed

ti-chi-bot added the affects-5.4 This bug affects 5.4.x versions. label Feb 14, 2022

morgo approved these changes Feb 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2022

mjonss approved these changes Feb 14, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022

seiya-annie approved these changes Feb 15, 2022

View reviewed changes

ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022

dveeden added 2 commits February 18, 2022 15:17

Merge remote-tracking branch 'upstream/master' into old_nopw_client

a250416

Fix 'Error return value of cc.authSwitchRequest is not checked (err…

3fa1d02

…check)'

hawkingrei approved these changes Feb 18, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2022

ti-chi-bot added 7 commits March 3, 2022 15:05

Merge branch 'master' into old_nopw_client

22a3aa5

Merge branch 'master' into old_nopw_client

008f340

Merge branch 'master' into old_nopw_client

9ff0d1f

Merge branch 'master' into old_nopw_client

d78e78f

Merge branch 'master' into old_nopw_client

ef70b06

Merge branch 'master' into old_nopw_client

30bf6c5

Merge branch 'master' into old_nopw_client

178ad04

ti-chi-bot merged commit 7e8ca4c into pingcap:master Mar 3, 2022

djshow832 added a commit to djshow832/tidb that referenced this pull request Mar 16, 2022

Revert "server: Improve compatibility with MySQL 5.5 and 5.6 clients (p…

8573e0f

…ingcap#32338)" This reverts commit 7e8ca4c.

This was referenced Mar 16, 2022

server: Revert "server: Improve compatibility with MySQL 5.5 and 5.6 clients … #33142

Merged

using MySQL 5.5 and 5.6 clients connecting with a passwordless account to tidb fail #32334

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: Improve compatibility with MySQL 5.5 and 5.6 clients #32338

server: Improve compatibility with MySQL 5.5 and 5.6 clients #32338

dveeden commented Feb 14, 2022 •

edited

ti-chi-bot commented Feb 14, 2022 •

edited

dveeden commented Feb 14, 2022

dveeden commented Feb 14, 2022

sre-bot commented Feb 14, 2022 •

edited

dveeden commented Feb 14, 2022 •

edited

mjonss left a comment

ti-chi-bot commented Feb 15, 2022

dveeden commented Feb 18, 2022 •

edited

hawkingrei commented Feb 18, 2022

hawkingrei commented Feb 18, 2022

zimulala commented Mar 3, 2022

ti-chi-bot commented Mar 3, 2022

server: Improve compatibility with MySQL 5.5 and 5.6 clients #32338

server: Improve compatibility with MySQL 5.5 and 5.6 clients #32338

Conversation

dveeden commented Feb 14, 2022 • edited

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Feb 14, 2022 • edited

dveeden commented Feb 14, 2022

dveeden commented Feb 14, 2022

sre-bot commented Feb 14, 2022 • edited

dveeden commented Feb 14, 2022 • edited

Without this PR

With this PR

mjonss left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Feb 15, 2022

dveeden commented Feb 18, 2022 • edited

hawkingrei commented Feb 18, 2022

hawkingrei commented Feb 18, 2022

zimulala commented Mar 3, 2022

ti-chi-bot commented Mar 3, 2022

dveeden commented Feb 14, 2022 •

edited

ti-chi-bot commented Feb 14, 2022 •

edited

sre-bot commented Feb 14, 2022 •

edited

dveeden commented Feb 14, 2022 •

edited

dveeden commented Feb 18, 2022 •

edited