Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: migrate test-infra to testify #32597

Merged
merged 5 commits into from
Feb 25, 2022
Merged

planner/core: migrate test-infra to testify #32597

merged 5 commits into from
Feb 25, 2022

Conversation

tisonkun
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #26857 close #28411

None

/cc @hawkingrei @rebelice

@tisonkun
planner/core: migrate test-infra to testify
0641160 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@tisonkun
Copy link
Contributor Author

/run-unit-test

@tisonkun tisonkun mentioned this pull request Feb 25, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/577a3b09a22e296974d720aa19a6e0324020c1f0

@xuyifangreeneyes
Copy link
Contributor

/cc @xuyifangreeneyes

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2022
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e35837d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 25, 2022
@ti-chi-bot ti-chi-bot merged commit ac04f2e into pingcap:master Feb 25, 2022
@tisonkun tisonkun deleted the issue-26857 branch February 25, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@rebelice rebelice rebelice approved these changes

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@tisonkun @ti-chi-bot @hawkingrei @sre-bot @xuyifangreeneyes @rebelice