plan: new plan support index look up join. #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
added
Priority/P1
XuHuaiyu
reviewed
May 18, 2017
plan/new_physical_plan_builder.go
Outdated
| @@ -113,6 +113,168 @@ func (p *Projection) convert2NewPhysicalPlan(prop *requiredProp) (taskProfile, e | |||
| return task, p.storeTaskProfile(prop, task) | |||
| } | |||
|
|
|||
| func (p *LogicalJoin) getIndexJoinKey(inner Plan) []*expression.Column { | |||
There was a problem hiding this comment.
Remove this function since it is not called by others.
plan/new_physical_plan_builder.go
Outdated
| @@ -133,7 +295,7 @@ func (p *LogicalJoin) convert2NewPhysicalPlan(prop *requiredProp) (taskProfile, | |||
| default: | |||
| if p.preferUseMergeJoin() { | |||
| task, err = p.convert2MergeJoin(prop) | |||
| } else { | |||
| } else if task, err = p.tryToGetIndexJoin(prop); task == nil && err == nil { | |||
| // TODO: We will consider index look up join in the future. | |||
plan/plan.go
Outdated
| @@ -113,6 +113,15 @@ type requiredProp struct { | |||
| taskTp taskType | |||
| } | |||
|
|
|||
| func (p *requiredProp) checkMatchSchema(schema *expression.Schema) bool { | |||
There was a problem hiding this comment.
This function is not called by others.
plan/new_physical_plan_builder.go
Outdated
| return matchOffsets | ||
| } | ||
|
|
||
| func (p *LogicalJoin) convertToIndexJoin(prop *requiredProp, outerIdx int) (taskProfile, error) { |
There was a problem hiding this comment.
add a comment for outerIdx.
XuHuaiyu
reviewed
May 18, 2017
plan/new_physical_plan_builder.go
Outdated
|
|
||
| // convertToIndexJoin will generate index join by required properties and outerIndex. OuterIdx points out the outer child, | ||
| // because we will swap the children of join when the right child is outer child. | ||
| // First of all, we will extract th join keys for p's equal conditions. If the join keys can match some of the indices or pk |
XuHuaiyu
reviewed
May 18, 2017
plan/new_physical_plan_builder.go
Outdated
| return task, nil | ||
| } | ||
|
|
||
| func (p *LogicalJoin) tryToGetIndexJoin(prop *requiredProp) (taskProfile, error) { |
There was a problem hiding this comment.
add a comment for this function.
|
LGTM |
shenli
reviewed
May 18, 2017
| sql: "select /*+ TIDB_INLJ(t1, t2) */ * from t t1 left outer join t t2 on t1.a = t2.a and t2.b < 1", | ||
| best: "IndexJoin{TableReader(Table(t))->TableReader(Table(t)->Sel([lt(t2.b, 1)]))}(t1.a,t2.a)", | ||
| }, | ||
| // Test Index Join failed. |
There was a problem hiding this comment.
Fail to use index join
plan/new_physical_plan_builder.go
Outdated
| @@ -133,7 +295,7 @@ func (p *LogicalJoin) convert2NewPhysicalPlan(prop *requiredProp) (taskProfile, | |||
| default: | |||
| if p.preferUseMergeJoin() { | |||
| task, err = p.convert2MergeJoin(prop) | |||
| } else { | |||
| } else if task, err = p.tryToGetIndexJoin(prop); task == nil && err == nil { | |||
| // TODO: We will consider index look up join in the future. | |||
| return nil | ||
| } | ||
| for i, col := range p.tableInfo.Columns { | ||
| if mysql.HasPriKeyFlag(col.Flag) { |
There was a problem hiding this comment.
Should we consider composed primary key?
There was a problem hiding this comment.
composed primary key is index
| if !found { | ||
| return nil | ||
| } | ||
| if i+1 == len(keys) { |
There was a problem hiding this comment.
This is not "keys match all columns in index." but "all keys match columns in index."
|
@shenli PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I give up the old index look up join which uses apply and create a new indexJoin Plan.
@shenli @zimulala @winoros PTAL