Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash #32813

Merged
merged 4 commits into from
Mar 4, 2022
Merged

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash #32813

merged 4 commits into from
Mar 4, 2022

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Mar 3, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32814, pingcap/tiflash#4163

Problem Summary:

  1. if a fragment has two children, one's ExchangeSender is Broadcast Type, another's is Type PassThrough.
  2. This fragment should be singleton, but because of the wrong implementation, it isn't.
  3. So this fragment will generate two tasks, and the data will be double.

What is changed and how it works?

if there is one child with passthrough exchangeType, the fragment will be singleton.

Check List

Tests

  • Unit test

Release note

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2022
@LittleFall
Copy link
Contributor Author

/run-check-license

@sre-bot
Copy link
Contributor

sre-bot commented Mar 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cb28b2a9d7a27903b7db72de32010834932bb4e8

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8f0c08

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 4, 2022
@LittleFall
Copy link
Contributor Author

=== RUN TestCheckTiDBVersion
[2022/03/04 15:13:43.524 +08:00] [INFO] [version.go:360] ["detect server version"] [type=TiDB] [version=4.0.0]
[2022/03/04 15:13:43.524 +08:00] [INFO] [version.go:360] ["detect server version"] [type=TiDB] [version=9999.0.0]
[2022/03/04 15:13:43.524 +08:00] [INFO] [version.go:360] ["detect server version"] [type=TiDB] [version=6.0.0]
importer_test.go:287:
Error Trace: importer_test.go:287
Error: An error is expected but got nil.
Test: TestCheckTiDBVersion
--- FAIL: TestCheckTiDBVersion (0.00s)

@LittleFall
Copy link
Contributor Author

/run-unit-test

2 similar comments
@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit fcdbf82 into pingcap:master Mar 4, 2022
@LittleFall LittleFall deleted the bugfix/4163 branch March 4, 2022 09:41
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 4, 2022
@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.0
ce59125 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32837

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 4, 2022
@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.1
f5eeecd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32838

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 4, 2022
@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.2
20108d3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32839

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 4, 2022
@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.3
79e9949 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32840

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 4, 2022
@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.4
c635780 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32841

@windtalker windtalker mentioned this pull request Apr 11, 2022
Closed
ti-chi-bot pushed a commit that referenced this pull request Apr 12, 2022
@ti-srebot
planner: Fix the issue that TiDB may dispatch duplicated tasks to TiF…
7c5373d 
…lash (#32813) (#32839)

ref pingcap/tiflash#4163, close #32814
ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2022
@ti-srebot
planner: Fix the issue that TiDB may dispatch duplicated tasks to TiF…
9687ea4 
…lash (#32813) (#32841)

ref pingcap/tiflash#4163, close #32814
ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot
planner: Fix the issue that TiDB may dispatch duplicated tasks to TiF…
da3bcc6 
…lash (#32813) (#32840)

ref pingcap/tiflash#4163, close #32814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu fzhedu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB may dispatch duplicated tasks to different TiFlash node and produce wrong result.
6 participants
@LittleFall @ti-chi-bot @sre-bot @fzhedu @ti-srebot @windtalker