Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: support disabled status for binding #32819

Merged
merged 49 commits into from
Mar 16, 2022
Merged

bindinfo: support disabled status for binding #32819

merged 49 commits into from
Mar 16, 2022

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Mar 4, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary:

  • Support the disabled status for the binding.
  • update the status from using to enabled when upgrade

What is changed and how it works?

  • Support the disabled status for the binding.
  • update the status from using to enabled when upgrade

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent requested a review from qw4990 March 4, 2022 02:59
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2022
Reminiscent and others added 12 commits March 4, 2022 11:17
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 8, 2022
qw4990
qw4990 reviewed Mar 16, 2022
View reviewed changes
bindinfo/handle.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Mar 16, 2022
View reviewed changes
bindinfo/handle.go Outdated Show resolved Hide resolved
rebelice
rebelice reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

bindinfo/handle.go Outdated

record := &BindRecord{OriginalSQL: originalSQL, Db: db}
sqlDigest := parser.DigestNormalized(record.OriginalSQL)
oldRecord := h.GetBindRecord(sqlDigest.String(), originalSQL, db)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter db for GetBindRecord is useless. This is a historical question, we'd better refactor GetBindRecord to get rid of parameter db later.
As for now, we'd better remove parameter db for SetBindRecordStatus and use empty string instead of db to call GetBindRecord.

qw4990
qw4990 reviewed Mar 16, 2022
View reviewed changes
bindinfo/handle.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8f0977

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Mar 16, 2022

/merge

@Reminiscent
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e110e73 into pingcap:master Mar 16, 2022
@Reminiscent Reminiscent deleted the supportDisableStatus branch March 16, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice rebelice approved these changes

Assignees
No one assigned
Labels
epic/sql-plan-management release-note-none sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Reminiscent @ti-chi-bot @sre-bot @qw4990 @rebelice