statistics: add a more accurate upper bound to exponential backoff estimation strategy #32848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
size/M
12 tasks
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/82acabb237393c602192207dd7e983f5c69baada |
ti-chi-bot
added
the
needs-rebase
qw4990
approved these changes
Mar 10, 2022
ti-chi-bot
removed
the
needs-rebase
time-and-fate
commented
Mar 14, 2022
Comment on lines
-353
to
+356
| IndexLookUp_11 10129.18 root | ||
| ├─IndexRangeScan_8(Build) 10129.18 cop[tikv] table:keyword, index:itest(phonetic_code, keyword) range:("R1652" "ecg-monitor","R1652" "killers"), keep order:false | ||
| └─Selection_10(Probe) 10129.18 cop[tikv] gt(imdbload.keyword.keyword, "ecg-monitor"), lt(imdbload.keyword.keyword, "killers") | ||
| └─TableRowIDScan_9 10129.18 cop[tikv] table:keyword keep order:false | ||
| IndexLookUp_11 901.00 root | ||
| ├─IndexRangeScan_8(Build) 901.00 cop[tikv] table:keyword, index:itest(phonetic_code, keyword) range:("R1652" "ecg-monitor","R1652" "killers"), keep order:false | ||
| └─Selection_10(Probe) 901.00 cop[tikv] gt(imdbload.keyword.keyword, "ecg-monitor"), lt(imdbload.keyword.keyword, "killers") | ||
| └─TableRowIDScan_9 901.00 cop[tikv] table:keyword keep order:false |
There was a problem hiding this comment.
Actual row count: 0
time-and-fate
commented
Mar 14, 2022
Comment on lines
-363
to
+366
| IndexLookUp_11 935147.84 root | ||
| ├─IndexRangeScan_8(Build) 935147.84 cop[tikv] table:cast_info, index:itest2(nr_order, person_role_id, note) range:[NULL 2 "(key set pa: Florida",NULL 2 +inf], keep order:false | ||
| └─Selection_10(Probe) 935147.84 cop[tikv] ge(imdbload.cast_info.note, "(key set pa: Florida") | ||
| └─TableRowIDScan_9 935147.84 cop[tikv] table:cast_info keep order:false | ||
| IndexLookUp_11 144633.00 root | ||
| ├─IndexRangeScan_8(Build) 144633.00 cop[tikv] table:cast_info, index:itest2(nr_order, person_role_id, note) range:[NULL 2 "(key set pa: Florida",NULL 2 +inf], keep order:false | ||
| └─Selection_10(Probe) 144633.00 cop[tikv] ge(imdbload.cast_info.note, "(key set pa: Florida") | ||
| └─TableRowIDScan_9 144633.00 cop[tikv] table:cast_info keep order:false |
There was a problem hiding this comment.
Actual row count: 37928
winoros
reviewed
Mar 14, 2022
winoros
approved these changes
Mar 14, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 28736ac
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #22589 #32758
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note