Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: add warning message when the memory usage of the cache exceeds its capacity #32866

Merged
merged 30 commits into from
Mar 15, 2022
Merged

bindinfo: add warning message when the memory usage of the cache exceeds its capacity #32866

merged 30 commits into from
Mar 15, 2022

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Mar 7, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary:

  1. add warning message when the memory usage of the cache exceeds its capacity
  2. rename TiDBMemQuotaBindCache to TiDBMemQuotaBindingCache

What is changed and how it works?

  1. add warning message when the memory usage of the cache exceeds its capacity
  2. rename TiDBMemQuotaBindCache to TiDBMemQuotaBindingCache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent requested a review from qw4990 March 7, 2022 07:04
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2022
Reminiscent
Reminiscent commented Mar 7, 2022
View reviewed changes
bindinfo/bind_cache.go
Comment on lines +114 to +116
return true
}
return true
return false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug here, But for now, the return value has not been used yet.

Reminiscent
Reminiscent commented Mar 7, 2022
View reviewed changes
bindinfo/bind_cache.go Outdated
c.set(cacheKey, []*BindRecord{meta})
ok, err := c.set(cacheKey, []*BindRecord{meta})
if !ok {
logutil.BgLogger().Warn("[sql-bind] The binding is too large to be loaded into the cache")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether using the logutil.BgLogger().Warn or something else.

@Reminiscent Reminiscent requested a review from a team as a code owner March 7, 2022 09:46
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
qw4990
qw4990 reviewed Mar 10, 2022
View reviewed changes
bindinfo/handle.go
newCache.SetBindRecord(hash, newRecord)
err = newCache.SetBindRecord(hash, newRecord)
if err != nil && memExceededErr != nil {
memExceededErr = err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we break this loop if meet this error?

time-and-fate
time-and-fate reviewed Mar 14, 2022
View reviewed changes
bindinfo/session_handle.go Outdated
h.ch.SetBindRecord(hash, newRecord)
err := h.ch.SetBindRecord(hash, newRecord)
if err != nil {
logutil.BgLogger().Warn("[sql-bind] ", zap.Error(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this case possibly happen?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5525271

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cdbb67

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4425015

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/442501562d649a9edd84a968bc2ccb23c8ced955

@ti-chi-bot ti-chi-bot merged commit 911cf53 into pingcap:master Mar 15, 2022
@Reminiscent Reminiscent deleted the addWarning4bindCache branch March 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
epic/sql-plan-management release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Reminiscent @ti-chi-bot @sre-bot @qw4990 @time-and-fate