Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: Fix unexpected assertion failed error in conflicting pessimistic transaction. #32917

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Mar 8, 2022

What problem does this PR solve?

Issue Number: close #32943

Requires tikv/client-go#448

Problem Summary:

In some rare cases there might be false-positive assertion failure reported in pessimistic transactions that's rolled back by another conflicting transaction and involve non-locked secondary index keys. For detail see tikv/tikv#12113 .

It's fixed in tikv and client-go. This PR updates the dependency to client-go.

What is changed and how it works?

Check List

Tests

  • Unit test (tested in client-go and tikv).

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 8, 2022

@MyonKeminta MyonKeminta force-pushed the m/fix-assertion-fail-in-conflicting-pessimistic-transactoin branch from 81de462 to 8144deb Compare March 11, 2022 04:40
@MyonKeminta MyonKeminta marked this pull request as ready for review March 11, 2022 04:41
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2022
@MyonKeminta MyonKeminta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@MyonKeminta MyonKeminta force-pushed the m/fix-assertion-fail-in-conflicting-pessimistic-transactoin branch from 8144deb to b067c33 Compare March 11, 2022 04:46
@MyonKeminta MyonKeminta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2022
@MyonKeminta MyonKeminta force-pushed the m/fix-assertion-fail-in-conflicting-pessimistic-transactoin branch from b067c33 to eaafd12 Compare March 14, 2022 06:13
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2022
@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eaafd12

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@ti-chi-bot
Copy link
Member

@MyonKeminta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 76f2437 into pingcap:master Mar 15, 2022
@MyonKeminta MyonKeminta deleted the m/fix-assertion-fail-in-conflicting-pessimistic-transactoin branch March 15, 2022 08:31
xhebox pushed a commit to xhebox/tidb that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
5 participants