Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix data race in the AnalyzeColumnsExec #32979

Merged
merged 21 commits into from
Mar 14, 2022
Merged

executor: fix data race in the AnalyzeColumnsExec #32979

merged 21 commits into from
Mar 14, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 9, 2022 •
edited

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #32978

Problem Summary:

What is changed and how it works?

  • executor/analyze.go:707 it create a goroutine but it has not wg.Wait. so it is a goroutine leak. then it will cause a data race.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2022
@hawkingrei hawkingrei force-pushed the fix_data_race_analyze branch 2 times, most recently from f79416e to c141b16 Compare March 10, 2022 05:49
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/503811330c281f20cdce55b3634f17a70663d8f6

@hawkingrei
Copy link
Member Author

/cc @winoros @rebelice

@hawkingrei hawkingrei force-pushed the fix_data_race_analyze branch 2 times, most recently from c141b16 to f1da65a Compare March 10, 2022 13:42
@hawkingrei hawkingrei requested a review from Yisaer March 11, 2022 02:20
winoros
winoros reviewed Mar 11, 2022
View reviewed changes
executor/analyze.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2022
@hawkingrei hawkingrei requested a review from winoros March 11, 2022 11:54
@hawkingrei
fix
1da1d09
@hawkingrei
fix
7981607
@hawkingrei
fix
4761a4d
@hawkingrei
fix
524f9a5
@hawkingrei
try tikv disk full
b2125ce 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
try tikv disk full
fa97065 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
4b2dabd
@hawkingrei
fix
61299af
@hawkingrei
fix
154a5e9
@hawkingrei
fix
17e180a
@hawkingrei
add test
8a9eca8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
simple code
3e4fab1 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2022
@hawkingrei
improve log
cb43cf4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
improve log
2c4fdd4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
fix
dcfbbe1 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dcfbbe1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 0cd9b24 into pingcap:master Mar 14, 2022
@hawkingrei hawkingrei deleted the fix_data_race_analyze branch March 14, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@rebelice rebelice Awaiting requested review from rebelice

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the AnalyzeColumnsExec
6 participants
@hawkingrei @ti-chi-bot @sre-bot @rebelice @winoros @xuyifangreeneyes