Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the issue that "rename column" fails when changing column type concurrently #32993

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31075

Problem Summary:

create table t(a int, b int);

In session 1: alter table t change column b b double;(DDL1)
In session 2: alter table t rename column b to c; (DDL2)

Decode the ModifyColumn's args:
job.DecodeArgs(&jobParam.newCol, &jobParam.oldColName, jobParam.pos, &jobParam.modifyColumnTp, &jobParam.updatedAutoRandomBits, &jobParam.changingCol, &jobParam.changingIdxs)

The rename column uses the ModifyColumn job. But the rename column uses 4 args.
After running DDL1, we do DDL2 need to change column type with data. So we will add changingCol and changingIdxs to args but not updatedAutoRandomBits. So it will return an error.

What is changed and how it works?

Add updatedAutoRandomBits to the rename column operation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that "rename column" fails when changing column type concurrently.

@zimulala zimulala added type/bug-fix This PR fixes a bug. sig/sql-infra SIG: SQL Infra labels Mar 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2022

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@zimulala
Copy link
Contributor Author

PTAL @tangenta

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 124b0b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/run-unit-test

2 similar comments
@zimulala
Copy link
Contributor Author

/run-unit-test

@zimulala
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 644b783 into pingcap:master Mar 14, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 14, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33034

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 14, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33035

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 14, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33036

@zimulala zimulala deleted the zimuxia/rename-col branch March 14, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename column fail when doing column type change concurrently
7 participants