Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more test cases for auto-capture #32994

Merged
merged 4 commits into from
Mar 14, 2022
Merged

planner: add more test cases for auto-capture #32994

merged 4 commits into from
Mar 14, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 10, 2022

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary: planner: add more test cases for auto-capture

What is changed and how it works?

planner: add more test cases for auto-capture

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@qw4990
fixup
211d58c 
fixup

fixup

fixup

fixup

fixup

fixup

fixup
@qw4990 qw4990 added the sig/planner SIG: Planner label Mar 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 12, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9b3ce7deadcc81ecfd92ff34651445d457cb7217

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9b3ce7d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit bf3be20 into pingcap:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qw4990 @ti-chi-bot @sre-bot @Reminiscent @xuyifangreeneyes @hawkingrei