Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: implement backup & restore policy info #33007

Merged
merged 27 commits into from
Mar 15, 2022
Merged

br: implement backup & restore policy info #33007

merged 27 commits into from
Mar 15, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 11, 2022 •
edited

What problem does this PR solve?

Issue Number: close #32290

Problem Summary:
support backup and restore policy in full backup.

What is changed and how it works?

  1. Write policyInfos to BackupMeta when we are in full backup.
  2. Add --with-tidb-placement-policy to control whether restore policies by user.
  3. Restore policy as much as possible.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support backup and restore policies.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2022
@3pointer 3pointer force-pushed the add_policy branch 2 times, most recently from 10c2329 to 2f2626a Compare March 11, 2022 07:27
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ae707659a3df3f44a1a0eb76a03269a8355443a9

@3pointer 3pointer added the type/feature-request This is a feature requests on the product label Mar 11, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2022
@3pointer 3pointer marked this pull request as ready for review March 11, 2022 11:29
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2022
bb7133
bb7133 reviewed Mar 11, 2022
View reviewed changes
br/pkg/backup/client.go Outdated Show resolved Hide resolved
br/tests/br_tidb_placement_policy/run.sh Outdated Show resolved Hide resolved
br/tests/br_tidb_placement_policy/run.sh Show resolved Hide resolved
lcwangchao
lcwangchao reviewed Mar 12, 2022
View reviewed changes
br/pkg/task/restore.go Outdated Show resolved Hide resolved
lcwangchao
lcwangchao reviewed Mar 12, 2022
View reviewed changes
br/pkg/task/restore.go Outdated Show resolved Hide resolved
lcwangchao
lcwangchao reviewed Mar 14, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@lcwangchao lcwangchao mentioned this pull request Mar 14, 2022
Merged
15 tasks
lcwangchao
lcwangchao reviewed Mar 14, 2022
View reviewed changes
br/pkg/backup/client.go Show resolved Hide resolved
br/pkg/task/restore.go Outdated Show resolved Hide resolved
br/pkg/restore/db.go Outdated Show resolved Hide resolved
@3pointer 3pointer changed the title backup: implement backup policy info br: implement backup & restore policy info Mar 14, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 14, 2022
@3pointer
Copy link
Contributor Author

/run-integration-br-tests

@3pointer
Copy link
Contributor Author

/run-br-integration-tests

bb7133
bb7133 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@bb7133
Copy link
Member

bb7133 commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7fb17bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot
Copy link
Member

@3pointer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e0db77e into pingcap:master Mar 15, 2022
@lcwangchao lcwangchao mentioned this pull request Mar 16, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@lcwangchao lcwangchao

@bb7133 bb7133

Labels
release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/feature-request This is a feature requests on the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BR support for placement rules
5 participants
@3pointer @ti-chi-bot @sre-bot @bb7133 @lcwangchao