-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix a bug on generated column cause wrong read result #33050
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8d278cc445503e8674c68a756485abed56565466 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b5bf9b7
|
/merge |
/run-unit-test |
/run-unit-test |
/run-mysql-test |
/run-unit-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #33099 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #33100 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #33101 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #33102 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.3 in PR #33103 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.4 in PR #33104 |
PTAL @wjhuang2016 @lcwangchao |
What problem does this PR solve?
Issue Number: close #33038
Problem Summary:
What is changed and how it works?
When a batch of data (32 rows by default) is processed, but no row match, an empty chunk is returned.
The parent executor treat empty chunk as the reading process has finished.
So the
Next()
will never be called again!Only the first batch of chunk is handled, all the others are ignored.
Check List
Tests
Side effects
Documentation
Release note