Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: only users with SUPER or CONNECTION_ADMIN privilege can kill auto analyze #33057

Merged
merged 5 commits into from
Mar 15, 2022

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Mar 14, 2022

What problem does this PR solve?

Issue Number: close #33058

Problem Summary:
Users without privilege can kill auto analyze.

What is changed and how it works?

Only users with SUPER or CONNECTION_ADMIN privilege can kill auto analyze

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2022
@xuyifangreeneyes
Copy link
Contributor Author

@sre-bot
Copy link
Contributor

sre-bot commented Mar 14, 2022

Comment on lines 3084 to 3087
} else if raw.ConnectionID == util2.GetAutoAnalyzeProcID() {
// Only the users with the SUPER privilege can kill auto analyze.
err := ErrSpecificAccessDenied.GenWithStackByArgs("SUPER")
b.visitInfo = appendVisitInfo(b.visitInfo, mysql.SuperPriv, "", "", "", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically PROCESS privilege is required to kill connections that belong to other users. MySQL 8.0 changes this to requiring CONNECTION_ADMIN: https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_connection-admin

This helps avoid the problem that super is overloaded (it is used by too many features, which makes it less secure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@xuyifangreeneyes xuyifangreeneyes changed the title planner: only users with SUPER privilege can kill auto analyze planner: only users with SUPER or CONNECTION_ADMIN privilege can kill auto analyze Mar 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a80965e

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-triage-completed labels Mar 15, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4c94056 into pingcap:master Mar 15, 2022
@xuyifangreeneyes xuyifangreeneyes deleted the kill-privilege branch March 15, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

users without privilege can kill auto analyze
6 participants