Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix unstable test in the TestNotifyErrorWaitGroupWrapper #33063

Merged
merged 8 commits into from
Mar 15, 2022
Merged

util: fix unstable test in the TestNotifyErrorWaitGroupWrapper #33063

merged 8 commits into from
Mar 15, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 15, 2022 •
edited

What problem does this PR solve?

NotifyErrorWaitGroupWrapper should use the Multi-Producers scene. if producers work in a short time. the Wait will make the program early finish.

Issue Number: close #33062

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2022
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a599d32a0f72bfeaa9075f96363f0b4b809b33fc

@hawkingrei hawkingrei force-pushed the fix_TestNotifyErrorWaitGroupWrapper branch from ae733ef to 676b7a3 Compare March 15, 2022 02:18
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2022
@purelind
Copy link
Contributor

/run-mysql-test tidb-test=1613

@purelind
Copy link
Contributor

/run-mysql-test tidb-test=pr/1613

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2022
Defined2014
Defined2014 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset LGTM

executor/analyze.go Outdated Show resolved Hide resolved
executor/analyze.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e757922b078d568f63406103fda003f2086ed191

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@hawkingrei
go.mod: update freecach for golang1.18
8faebef 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: fix unstable test in the TestNotifyErrorWaitGroupWrapper
15c7156 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
try
86fba18 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
14f6b71 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: improve code
52ce947 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
add commnent
82a6fc7
@hawkingrei
add commnent
92d1b24
@hawkingrei hawkingrei force-pushed the fix_TestNotifyErrorWaitGroupWrapper branch from 50b4210 to 92d1b24 Compare March 15, 2022 14:13
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 92d1b24

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

2 similar comments
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 41fb3e7 into pingcap:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test in the TestNotifyErrorWaitGroupWrapper
6 participants
@hawkingrei @ti-chi-bot @sre-bot @purelind @tiancaiamao @Defined2014