Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpp: throw an err when mpp generate empty table scan task list #33084

Merged
merged 5 commits into from
Mar 16, 2022
Merged

mpp: throw an err when mpp generate empty table scan task list #33084

merged 5 commits into from
Mar 16, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 15, 2022

What problem does this PR solve?

Issue Number: close #33083

Problem Summary:

What is changed and how it works?

Now mpp cannot handle empty table scan task list.
We temporarily throw an error for this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@SeaRise SeaRise changed the title planner: throw an err when mpp generate empty table scan task list mpp: throw an err when mpp generate empty table scan task list Mar 15, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 15, 2022

/cc @windtalker @fuzhe1989 @LittleFall

windtalker
windtalker approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 15, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3e909673e4b9d55d112420ef8c8d991bdc679437

LittleFall
LittleFall approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2022

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2022

/run-cherry-picker

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e90967

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@ti-chi-bot ti-chi-bot merged commit 383f0bb into pingcap:master Mar 16, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@SeaRise @ti-srebot
cherry pick pingcap#33084 to release-5.1
a13fb4d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33135

@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@SeaRise @ti-srebot
cherry pick pingcap#33084 to release-5.2
3833c4c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33136

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@SeaRise @ti-srebot
cherry pick pingcap#33084 to release-5.3
b65e42b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33137

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@SeaRise @ti-srebot
cherry pick pingcap#33084 to release-5.4
54f6413 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33138

ti-chi-bot pushed a commit that referenced this pull request Apr 14, 2022
@ti-srebot
mpp: throw an err when mpp generate empty table scan task list (#33084)…
f155f58 
… (#33136)

close #33083
ti-chi-bot pushed a commit that referenced this pull request Apr 24, 2022
@ti-srebot
mpp: throw an err when mpp generate empty table scan task list (#33084)…
0245406 
… (#33138)

close #33083
@SeaRise SeaRise deleted the fix_issue_4071 branch April 24, 2022 06:38
@zanmato1984
Copy link
Contributor

update

ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot
mpp: throw an err when mpp generate empty table scan task list (#33084)…
faba7c1 
… (#33137)

close #33083
ti-chi-bot pushed a commit that referenced this pull request Jun 21, 2022
@ti-srebot
mpp: throw an err when mpp generate empty table scan task list (#33084)…
2c7c95a 
… (#33135)

close #33083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@LittleFall LittleFall LittleFall approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of subquery with all is not correct
7 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @ti-srebot @zanmato1984 @LittleFall