Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the wrong range built for bit columns when reusing cached plan #33090

Merged
merged 4 commits into from
Mar 15, 2022
Merged

planner: fix the wrong range built for bit columns when reusing cached plan #33090

merged 4 commits into from
Mar 15, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 15, 2022

What problem does this PR solve?

Issue Number: close #33067

Problem Summary: planner: fix the wrong range built for bit columns when reusing cached plan

What is changed and how it works?

planner: fix the wrong range built for bit columns when reusing cached plan

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@qw4990 qw4990 added type/bug-fix This PR fixes a bug. sig/planner SIG: Planner labels Mar 15, 2022
@qw4990 qw4990 requested a review from Reminiscent March 15, 2022 09:51
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2022
@qw4990 qw4990 added affects-5.4 This bug affects 5.4.x versions. affects-6.0 labels Mar 15, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed labels Mar 15, 2022
@qw4990 qw4990 added affects-5.3 This bug affects 5.3.x versions. do-not-merge/needs-triage-completed and removed needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-6.0 labels Mar 15, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed labels Mar 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b0f4b2e1252545bceba91515ae22e964d794387e

@qw4990 qw4990 requested a review from rebelice March 15, 2022 10:49
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 319ac74

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot ti-chi-bot merged commit caad839 into pingcap:master Mar 15, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 15, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 15, 2022
@qw4990 @ti-srebot
cherry pick pingcap#33090 to release-5.3
fafc7ab 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33095

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 15, 2022
@qw4990 @ti-srebot
cherry pick pingcap#33090 to release-5.4
aa5f87d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 15, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33096

@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 failed

ti-chi-bot pushed a commit that referenced this pull request Sep 22, 2022
@ti-srebot
planner: fix the wrong range built for bit columns when reusing cache…
b9cf8d9 
…d plan (#33090) (#33096)

close #33067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong IndexRangeScan for bit column
6 participants
@qw4990 @ti-chi-bot @sre-bot @rebelice @ti-srebot @Reminiscent