Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix load stat for new collation column #33146

Merged
merged 2 commits into from
Mar 16, 2022
Merged

statistics: fix load stat for new collation column #33146

merged 2 commits into from
Mar 16, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 16, 2022 •
edited

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #31765

Problem Summary:
The length of sortKey maybe longer than the column's length.

What is changed and how it works?

Modify the column length temporarily.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
77b776e 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b3d934811c11695406638e77b0dd917c039fd036

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77b776e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit 128dc16 into pingcap:master Mar 16, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-4.0
18e9f1b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33150

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-5.0
56e04b3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33151

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-5.1
ecfcaf3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33152

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-5.2
a19fcf1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33153

@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33154

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-5.3
d58b2af 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 16, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33146 to release-5.4
53a2bf5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 16, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33155

@time-and-fate time-and-fate mentioned this pull request Jul 29, 2022
Merged
12 tasks
This was referenced Jul 29, 2022
Merged
Merged
@wjhuang2016 wjhuang2016 deleted the fix_load_stat branch November 17, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't not load stat when new collation is enabled.
7 participants
@wjhuang2016 @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @winoros @time-and-fate