Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: migrate test-infra to testify for ddl.testDBSuite5 #33157

Merged
merged 2 commits into from
Mar 16, 2022
Merged

ddl: migrate test-infra to testify for ddl.testDBSuite5 #33157

merged 2 commits into from
Mar 16, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: close #32965

None

/cc @hawkingrei @xhebox @wjhuang2016

@tisonkun
ddl: migrate test-infra to testify for ddl.testDBSuite5
e62fe8c 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from xhebox March 16, 2022 10:53
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6b176fe8a9048ef8a9a9f27099075125fb9480d6

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@xhebox
Copy link
Contributor

xhebox commented Mar 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e62fe8c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2022
@tisonkun
Copy link
Contributor Author

/run-unit-test

1 similar comment
@tisonkun
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit c4fbc8e into pingcap:master Mar 16, 2022
@tisonkun tisonkun deleted the issue-32965 branch March 16, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for ddl.testDBSuite5
5 participants
@tisonkun @ti-chi-bot @sre-bot @xhebox @wjhuang2016