Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update Performance Overview dashboard #33398

Merged
merged 4 commits into from Mar 27, 2022

Conversation

Yui-Song
Copy link
Contributor

@Yui-Song Yui-Song commented Mar 24, 2022

What problem does this PR solve?

Issue Number: close #33477

Update Performance Overview Dashboard to show the number of Failed Query, TiKV IO metrics and reoder some panels.

What is changed and how it works?

  1. Failed Query is added in the "QPS" panel.
    image

  2. TiKV IO MBps data combined with TiKV CPU metrics are shown in the "TiKV CPU/IO MBps" panel
    image

  3. Reorder the following panels to show the duration of each operation articulately.
    image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 24, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@Yui-Song Yui-Song changed the title Update Performance Overview dashboard metrics: Update Performance Overview dashboard Mar 24, 2022
@tiancaiamao tiancaiamao changed the title metrics: Update Performance Overview dashboard metrics: update Performance Overview dashboard Mar 25, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@tiancaiamao
Copy link
Contributor

/run-unit-test

@tiancaiamao
Copy link
Contributor

image

It's better to attach a url link for how this dashboard looks like for such kind of PR.
The code differences are not readable.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2022

@Yui-Song
Copy link
Contributor Author

image

It's better to attach a url link for how this dashboard looks like for such kind of PR. The code differences are not readable.

Got it! I attached screenshots when updating the dbaas repo but forggot to put them here. Sorry!

@hawkingrei hawkingrei requested a review from jackysp March 26, 2022 03:11
@hawkingrei
Copy link
Member

@jackysp PTAL

@jackysp
Copy link
Member

jackysp commented Mar 26, 2022

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 26, 2022

Visit the grafana server at: http://172.16.5.5:31173, it will last for 5 hours

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2022
@hawkingrei
Copy link
Member

@Yui-Song You need to create an enhancement issue. then link this issue into this pr description.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 697e611

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2022
@ti-chi-bot ti-chi-bot merged commit e318f51 into pingcap:master Mar 27, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 27, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show failed query information and TiKV IO metrics in Performance Overview dashboard
7 participants