Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-binlog/pump_client: migrate test-infra to testify #33475

Merged
merged 1 commit into from Mar 27, 2022
Merged

tidb-binlog/pump_client: migrate test-infra to testify #33475

merged 1 commit into from Mar 27, 2022

Conversation

zanpocc
Copy link
Contributor

@zanpocc zanpocc commented Mar 26, 2022

What problem does this PR solve?

Issue Number: close #33463

Problem Summary: migrate test-infra to testify for tidb-binlog/pump_client pkg

What is changed and how it works?

  • replace the pingcap/check of the tidb-binlog/pump_client package test code with the testify.
  • basic test code using testify

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @zanpocc!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@sre-bot
Copy link
Contributor

sre-bot commented Mar 26, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Mar 26, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fe2b7f989cd1387983e6cdadceb9b979409bede4

@zanpocc zanpocc changed the title migrate test-infra to testify #33463 tidb-binlog/pump_client: migrate test-infra to testify #33463 Mar 26, 2022
tisonkun
tisonkun requested changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @zanpocc ! Comments inline.

tidb-binlog/pump_client/bench_test.go Outdated Show resolved Hide resolved
tidb-binlog/pump_client/bench_test.go Outdated Show resolved Hide resolved
@zanpocc zanpocc requested a review from tisonkun March 26, 2022 14:10
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2022
@tisonkun
Copy link
Contributor

/cc @hawkingrei @xhebox

@zanpocc
Copy link
Contributor Author

zanpocc commented Mar 26, 2022

/run-unit-test

@tisonkun tisonkun changed the title tidb-binlog/pump_client: migrate test-infra to testify #33463 tidb-binlog/pump_client: migrate test-infra to testify Mar 27, 2022
@tisonkun
Copy link
Contributor

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe2b7f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2022
@ti-chi-bot ti-chi-bot merged commit e09bc29 into pingcap:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for tidb-binlog/pump_client pkg
6 participants
@zanpocc @ti-chi-bot @CLAassistant @sre-bot @tisonkun @hawkingrei