Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix append to result twice when vecEval compress('') #33523

Merged
merged 4 commits into from Mar 29, 2022
Merged

expression: fix append to result twice when vecEval compress('') #33523

merged 4 commits into from Mar 29, 2022

Conversation

UBarney
Copy link
Contributor

@UBarney UBarney commented Mar 29, 2022

What problem does this PR solve?

Issue Number: close #33397

Problem Summary: append to result twice when vecEval compress('')

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@sre-bot
Copy link
Contributor

sre-bot commented Mar 29, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0cfb6aa3bd0e8fc7bd182722b0cdb438b8a866ab

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5030ffa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@ti-chi-bot ti-chi-bot merged commit 5a54d0d into pingcap:master Mar 29, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-4.0
6868cbe 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33550

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-5.0
a8d293f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33551

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-5.1
5cbe69d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33552

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-5.2
ab3a7d8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33554

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-5.3
0079ce6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33555

@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-5.4
1670aa2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33557

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@UBarney @ti-srebot
cherry pick pingcap#33523 to release-6.0
7d75c3e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33558

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
expression: fix append to result twice when vecEval compress('') (#33523
da5f372 
) (#33557)

close #33397
ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot
expression: fix append to result twice when vecEval compress('') (#33523
ea70ff1 
) (#33555)

close #33397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should ensure all columns have the same length, expect 103, but got 104
6 participants
@UBarney @ti-chi-bot @sre-bot @Defined2014 @ti-srebot @xiongjiwei