Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: use the correct unit for pausing schedulers #33545

Merged
merged 6 commits into from
Apr 8, 2022
Merged

br: use the correct unit for pausing schedulers #33545

merged 6 commits into from
Apr 8, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 29, 2022 •
edited

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: close #33546.

Problem Summary: The unit for TTL of schedulers is not correct. We should use second as the unit.

What is changed and how it works?

Check List

Tests

  • Manual test
  1. start a cluster with TiUP
  2. use lightning to import data
  3. kill lightning with kill -9

Here is the log of PD:

[2022/03/29 14:26:07.097 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-region-scheduler] [pause-seconds=300]
[2022/03/29 14:26:07.097 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-leader-scheduler] [pause-seconds=300]
[2022/03/29 14:26:07.098 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-hot-region-scheduler] [pause-seconds=300]

Release note

Fix the issue that the schedulers won't be resumed after BR/Lightning exits abnormally.

@rleungx
use the correct unit
2cc7de5 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed release-note and removed do-not-merge/needs-linked-issue release-note-none labels Mar 29, 2022
@rleungx rleungx changed the title br: use the correct unit br: use the correct unit for pausing schedulers Mar 29, 2022
@rleungx rleungx marked this pull request as ready for review March 29, 2022 06:38
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2022
@glorv glorv added affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-6.0 and removed do-not-merge/needs-triage-completed affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 labels Mar 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 29, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0cc6d9aff7c8e943990ddac25d0d139eedf2331b

@glorv glorv mentioned this pull request Mar 30, 2022
Open
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2022
@glorv
Copy link
Contributor

glorv commented Apr 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d9880e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2022
@ti-chi-bot ti-chi-bot merged commit 53042e7 into pingcap:master Apr 8, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@rleungx @ti-srebot
cherry pick pingcap#33545 to release-5.2
1273b8b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33813

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@rleungx @ti-srebot
cherry pick pingcap#33545 to release-5.3
1e474e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33815

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@rleungx @ti-srebot
cherry pick pingcap#33545 to release-5.4
d7b7b4b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33816

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 8, 2022
@rleungx @ti-srebot
cherry pick pingcap#33545 to release-6.0
187a8fb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 8, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33817

@sleepymole sleepymole mentioned this pull request Apr 25, 2022
Closed
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
br: use the correct unit for pausing schedulers (#33545) (#33816)
a6848c4 
close #33546
ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2022
@ti-srebot
br: use the correct unit for pausing schedulers (#33545) (#33815)
9b8d573 
close #33546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduler won't resume if lightning exits abnormally
6 participants
@rleungx @ti-chi-bot @sre-bot @glorv @ti-srebot @JmPotato